Open
Conversation
Signed-off-by: Benedikt Johannes <benedikt.johannes.hofer@gmail.com>
sacpis
approved these changes
Mar 30, 2026
Collaborator
Command Bot: Processing... |
sacpis
reviewed
Mar 30, 2026
| __qpu__ auto operator()(const int n_qubits, CallableKernel &&oracle, | ||
| const long target_state) { | ||
| int n_iterations = round(0.25 * M_PI * sqrt(2 ^ n_qubits)); | ||
| int n_iterations = round(0.25 * M_PI * sqrt(std::pow(2, n_qubits))); |
Collaborator
There was a problem hiding this comment.
Can you please fix the MLIR below? You will need to replace arith.xori.
Collaborator
There was a problem hiding this comment.
nit: I don't think you need to specify the namespace std::, as already have included cmath lib.
sacpis
requested changes
Mar 30, 2026
Collaborator
|
Would like to request to run the test or any relevant file after you make changes. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.