Format native sources after cudf sync - #4778
Conversation
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
Greptile SummaryThis PR applies the clang-format pre-commit hook output after the cudf submodule sync in #4777, and updates expired copyright years across the same 26 files. All changes are purely mechanical with no logic, behavior, or API alterations.
Confidence Score: 5/5Safe to merge — purely mechanical clang-format output with no logic, algorithm, or API changes. Every changed line is either a No files require special attention. The copyright format difference in Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[cudf submodule sync - PR 4777] --> B[pre-commit clang-format hook\ndetects style drift]
B --> C{Files modified?}
C -- Yes --> D[Apply east-const formatting\nconst T → T const\nacross 26 native source files]
D --> E[Update expired copyright years\n2024/2025 → 2026]
E --> F[pre-commit.ci - pr passes\non head ef703bfb]
C -- No --> F
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[cudf submodule sync - PR 4777] --> B[pre-commit clang-format hook\ndetects style drift]
B --> C{Files modified?}
C -- Yes --> D[Apply east-const formatting\nconst T → T const\nacross 26 native source files]
D --> E[Update expired copyright years\n2024/2025 → 2026]
E --> F[pre-commit.ci - pr passes\non head ef703bfb]
C -- No --> F
Reviews (3): Last reviewed commit: "Apply suggestion from @ttnghia" | Re-trigger Greptile |
|
build |
|
Should fix the licence header first. |
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
|
Fixed in I updated the eight files reported by The new head already has |
|
build |
|
|
duplicated with #4780 |
|
build |
Summary
mainlicense-header-checkWhy
A local merge of #4752 onto current
origin/mainreproduced the currentpre-commit.ci - prfailure: theclang-formathook modified native source files after the cudf sync in #4777. This PR applies those hook-generated changes directly on top of currentmain, then fixes the license-header files reported by the maintainer-triggered check.Validation
pre-commit run clang-format --all-files --verboseinitially reproduced the same files-were-modified failurepre-commit.ci - prpasses on headef703bfblicense-header-checkregex passes for the 23 included changed filesuvx pre-commit run --files src/main/cpp/faultinj/faultinj.cu src/main/cpp/profiler/ProfilerJni.cpp src/main/cpp/profiler/init_nvtxw.cpp src/main/cpp/profiler/spark_rapids_profile_converter.cpp src/main/cpp/src/KudoGpuSerializerJni.cpp src/main/cpp/src/zorder.cu src/main/cpp/tests/exception_with_row_index.cpp src/main/cpp/tests/multiply.cpp --verbosepassesgit diff --checkpassesgit diff --check origin/main...HEADpasses