Skip to content

Replace Apache Thrift by cudf APIs for Parquet footer reading/writing #4851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ttnghia wants to merge 2 commits into
base: main
Choose a base branch
from
+462 −138
Open

Replace Apache Thrift by cudf APIs for Parquet footer reading/writing #4851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c016e88
[Refactor] Drop Thrift from `NativeParquetJni` via cudf facade
ttnghia Jul 19, 2026
aa97d99
[Fix] Guard footer buffer length and document decode assumptions
ttnghia Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions src/main/cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,28 +175,9 @@ find_library(ARROW_LIB "libarrow.a" REQUIRED NO_DEFAULT_PATH
HINTS "${CUDFJNI_BUILD_DIR}/_deps/arrow-build/release/"
)

# parquet
find_library(PARQUET_LIB "libparquet.a" REQUIRED NO_DEFAULT_PATH
HINTS "${CUDFJNI_BUILD_DIR}/_deps/arrow-build/release/"
)

# Internal parquet headers
set (GENERATED_PARQUET_INCLUDE
"${CUDFJNI_BUILD_DIR}/_deps/arrow-src/cpp/src/"
CACHE STRING "generated parquet thrift headers"
)

# thrift
find_library(THRIFT_LIB "libthrift.a" REQUIRED NO_DEFAULT_PATH
HINTS "${CUDFJNI_BUILD_DIR}/lib/"
)

set(CUDFJNI_INCLUDE_DIRS
"${CUDF_DIR}/java/src/main/native/include"
"${CUDF_DIR}/java/src/main/native/src"
"${GENERATED_PARQUET_INCLUDE}"
"${CUDFJNI_BUILD_DIR}/_deps/thrift-build/"
"${CUDFJNI_BUILD_DIR}/_deps/thrift-src/lib/cpp/src/"
)

# ##################################################################################################
Expand Down Expand Up @@ -346,8 +327,6 @@ target_link_libraries(
cuco::cuco
spdlog::spdlog_header_only
${ARROW_LIB}
${PARQUET_LIB}
${THRIFT_LIB}
)
rapids_cuda_set_runtime(spark_rapids_jni USE_STATIC ON)
set_target_properties(spark_rapids_jni PROPERTIES LINK_LANGUAGE "CXX")
Expand Down
Loading