[auto-merge] bot-auto-merge-release/26.08 to main [skip ci] [bot] - #4941
Merged
Conversation
Fixes #4937. ## Summary - restore the JNI build toolchain to GCC 14 - replace the `shuffle_split` `std::pair` return type with an aggregate result - preserve structured-binding behavior and update the explicit test container type ## Root cause CUDA 12.9 `cudafe++` crashes while instantiating GCC 14's concepts-based `std::pair` constructor constraints for the shuffle result types. This previously forced the JNI build back to GCC 13. ARM64 nvCOMP 5.3 is built with GCC 14 and requires `__cxa_call_terminate`, which the GCC 13 link does not provide. Using an aggregate avoids the compiler crash without changing the shuffle algorithm. GCC 14 can then link nvCOMP 5.3 and supplies `__cxa_call_terminate` through its nonshared compatibility library, without adding a newer dynamic libstdc++ requirement. This replaces the GCC 13 toolchain workaround introduced by #4468 while retaining compatibility with CUDA 12.9. ## Validation - reproduced the ARM64 GCC 13 final-link failure: nvCOMP 5.3.0.16 contains 20 undefined `__cxa_call_terminate` references, and GCC 13 does not provide the symbol - passed the matching ARM64 Rocky Linux 8 GCC 14 final-link probe; GCC 14 provides `__cxa_call_terminate` through `libstdc++_nonshared.a` - reproduced the `shuffle_split.cu` crash with CUDA 12.9.86 and GCC 14.2.1 before the change - compiled and linked the JNI native libraries with CUDA 12.9.86, GCC 14.2.1, and nvCOMP 5.3.0.16 after the change - verified the resulting `libcudf.so` has no unresolved relocations with Rocky Linux 8 `libstdc++.so.6.0.25` - completed a clean x86_64 package build with CUDA 12.9.86 and GCC 14.2.1 - passed all 18 `SHUFFLE_SPLIT` native tests, including `MixedValidity` - repository-pinned clang-format v20.1.8 passes --------- Signed-off-by: Chong Gao <chongg@nvidia.com> Co-authored-by: Chong Gao <res_life@163.com>
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Collaborator
Author
|
SUCCESS - auto-merge |
Contributor
Greptile SummaryThis automated upmerge advances the cuDF submodule and related dependency pins toward main/26.10, adopts GCC 14 in the build environment, and replaces the shuffle split
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code failure identified. The shuffle return-type migration covers pair-specific callers while preserving structured bindings, the compiler package and activation changes are coordinated, and the dependency-pin updates reveal no established incompatibility. Important Files Changed
Reviews (1): Last reviewed commit: "Auto-merge use main versions" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
auto-merge triggered by github actions on
bot-auto-merge-release/26.08to create a PR keepingmainup-to-date. If this PR is unable to be merged due to conflicts, it will remain open until manually fix.