[CI] Use dedicated Apache mirror for Thrift - #4943
Merged
Merged
Conversation
Update the premerge build to download Arrow's Apache Thrift tarball through sw-spark-apache-remote instead of sw-spark-maven/apache-remote. The dedicated Generic Artifactory remote is backed by archive.apache.org and automatically caches Apache tarballs, avoiding the manual uploads required by the Maven repository path. Continue authenticating through ~/.netrc with CMAKE_NETRC=OPTIONAL, and run the cuDF build through common.shWithRedactedAuthorization so CMake/libcurl failures cannot expose credentials in the Jenkins console while pipefail preserves the original command failure. Signed-off-by: Tim Liu <timl@nvidia.com>
Collaborator
Author
|
build |
Contributor
Greptile SummaryThe PR updates premerge CI to fetch Arrow’s Apache Thrift tarball through the dedicated Apache Artifactory remote while retaining netrc authentication and adding credential-safe build-output redaction.
Confidence Score: 5/5The PR appears safe to merge, with no concrete blocking or non-blocking defects identified in the changed CI path. The mirror URL composes with the existing Thrift archive path, netrc handling remains enabled, and the build command itself is unchanged apart from being passed through the credential-redaction helper. Important Files Changed
Reviews (1): Last reviewed commit: "[CI] Use dedicated Apache mirror for Thr..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #4942
Update the premerge build to download Arrow's Apache Thrift tarball through sw-spark-apache-remote instead of sw-spark-maven/apache-remote.
The dedicated Generic Artifactory remote is backed by archive.apache.org and automatically caches Apache tarballs, avoiding the manual uploads required by the Maven repository path.
Continue authenticating through ~/.netrc with CMAKE_NETRC=OPTIONAL, and run the cuDF build through common.shWithRedactedAuthorization so CMake/libcurl failures cannot expose credentials in the Jenkins console while pipefail preserves the original command failure.