Add create table as select support for iceberg. - #13595
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Iceberg CREATE TABLE AS SELECT (CTAS) operations on GPU by extending the existing Iceberg provider infrastructure to handle AtomicCreateTableAsSelectExec operations.
Key changes:
- Extended IcebergProvider interface with CTAS support methods
- Added GPU tagging and conversion logic for CTAS operations
- Implemented comprehensive test coverage for various CTAS scenarios
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ExternalSource.scala | Added CTAS support to GPU tagging and conversion logic |
| IcebergProvider.scala | Extended interface with CTAS-specific methods |
| iceberg_ctas_test.py | Comprehensive test suite covering CTAS scenarios and fallback cases |
| GpuSparkWrite.scala | Added CTAS-specific GPU tagging method with validation logic |
| package.scala | Added catalog support utility function |
| IcebergProviderImpl.scala | Implemented CTAS support methods with GPU conversion |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
liurenjie1024
force-pushed
the
ray/13521
branch
from
October 10, 2025 10:10
7419069 to
9408bbe
Compare
Collaborator
Author
|
build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13521 .
Description
Add create table as select support for iceberg.
Checklists
(Please explain in the PR description how the new code paths are tested, such as names of the new/existing tests that cover them.)