Add insert static overwrite support for iceberg. - #13611
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds GPU support for Iceberg INSERT OVERWRITE (static overwrite) operations by implementing the OverwriteByExpressionExec execution plan on GPU. The implementation follows a similar pattern to the existing AppendDataExec GPU support.
Key changes:
- Adds GPU execution plan class
GpuOverwriteByExpressionExecfor overwrite operations - Implements Iceberg-specific GPU write support for overwrite with
GpuOverwriteByFilterclass - Adds comprehensive integration tests covering various scenarios and fallback cases
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
tools/generated_files/354/supportedExecs.csv |
Adds OverwriteByExpressionExec to supported GPU operations list |
tools/generated_files/354/operatorsScore.csv |
Adds scoring entry for OverwriteByExpressionExec |
sql-plugin/src/main/spark350/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala |
Implements GpuOverwriteByExpressionExec GPU execution plan class |
sql-plugin/src/main/spark350/scala/com/nvidia/spark/rapids/shims/Spark350PlusNonDBShims.scala |
Registers the new execution plan in the GPU conversion rules |
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/ExternalSource.scala |
Adds external source support for overwrite operations |
sql-plugin/src/main/scala/com/nvidia/spark/rapids/v2WriteCommandMetas.scala |
Implements metadata handling for overwrite operations |
sql-plugin/src/main/scala/com/nvidia/spark/rapids/iceberg/IcebergProvider.scala |
Extends provider interface for overwrite support |
integration_tests/src/main/python/iceberg/iceberg_overwrite_static_test.py |
Comprehensive test suite for overwrite functionality |
iceberg/src/main/scala/org/apache/iceberg/spark/source/write.scala |
Implements GpuOverwriteByFilter batch write class |
iceberg/src/main/scala/org/apache/iceberg/spark/source/GpuSparkWrite.scala |
Updates GPU write logic to handle overwrite operations |
iceberg/src/main/scala/com/nvidia/spark/rapids/iceberg/IcebergProviderImpl.scala |
Implements Iceberg-specific overwrite GPU conversion logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
res-life
reviewed
Oct 16, 2025
|
|
||
| override def tagForGpu(cpuExec: OverwriteByExpressionExec, | ||
| meta: OverwriteByExpressionExecMeta): Unit = { | ||
| if (!meta.conf.isIcebergEnabled) { |
Collaborator
Author
|
build |
res-life
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13605 .
Description
Add insert static overwrite support for iceberg.
Checklists
(Please explain in the PR description how the new code paths are tested, such as names of the new/existing tests that cover them.)