Skip to content

Migrate most remaining NvtxRanges to use NvtxId/NvtxRangeWithDoc - #13614

Merged
zpuller merged 15 commits into
NVIDIA:branch-25.12from
zpuller:cursor_nvtx
Oct 21, 2025
Merged

Migrate most remaining NvtxRanges to use NvtxId/NvtxRangeWithDoc#13614
zpuller merged 15 commits into
NVIDIA:branch-25.12from
zpuller:cursor_nvtx

Conversation

@zpuller

@zpuller zpuller commented Oct 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

This PR migrates most the remaining NvtxRanges to use the documented NvtxId wrappers, which will get auto generated into a docs page.

Checklists

  • This PR has added documentation for new or modified features or behaviors.
  • This PR has added new tests or modified existing tests to cover new code paths.
    (Please explain in the PR description how the new code paths are tested, such as names of the new/existing tests that cover them.)
  • Performance testing has been performed and its results are added in the PR description. Or, an issue has been filed with a link in the PR description.

zpuller added 13 commits October 15, 2025 11:30
@zpuller
migrate base nvtx ranges
ec5c7af 
Signed-off-by: Zach Puller <zpuller@nvidia.com>
@zpuller
migrate asymmetrical ranges
0f4f64c 
Signed-off-by: Zach Puller <zpuller@nvidia.com>
@zpuller
migrate some NvtxWithMetrics to NvtxIdWithMetrics
c7258a1 
Signed-off-by: Zach Puller <zpuller@nvidia.com>
@zpuller
migrate more NvtxWithMetrics to NvtxIdWithMetrics
a18e3ab 
Signed-off-by: Zach Puller <zpuller@nvidia.com>
@zpuller
migrate spill framework
798754f 
Signed-off-by: Zach Puller <zpuller@nvidia.com>
@zpuller
migrate remaining ranges
756acba 
Signed-off-by: Zach Puller <zpuller@nvidia.com>
@zpuller
more
ccefc65 
Signed-off-by: Zach Puller <zpuller@nvidia.com>
@zpuller
verify
a01af80 
Signed-off-by: Zach Puller <zpuller@nvidia.com>
@zpuller
migrate more
4d1f511 
Signed-off-by: Zach Puller <zpuller@nvidia.com>
@zpuller
fix GpuCoalesceBatches
07680bc 
Signed-off-by: Zach Puller <zpuller@nvidia.com>
@zpuller
revert changes in Plugin.scala
2671bb8 
Signed-off-by: Zach Puller <zpuller@nvidia.com>
@zpuller
verify
aa3212a 
Signed-off-by: Zach Puller <zpuller@nvidia.com>
@zpuller
license header
e6e192f 
Signed-off-by: Zach Puller <zpuller@nvidia.com>
@zpuller

zpuller commented Oct 15, 2025

Copy link
Copy Markdown
Collaborator Author

build

@zpuller
fix CI
213f364 
Signed-off-by: Zach Puller <zpuller@nvidia.com>
@zpuller

zpuller commented Oct 16, 2025

Copy link
Copy Markdown
Collaborator Author

build

@zpuller
zpuller marked this pull request as ready for review October 16, 2025 06:18
abellina
abellina reviewed Oct 16, 2025
View reviewed changes
Comment thread sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuColumnarBatchSerializer.scala Outdated
@zpuller
pr comment
4c2145d 
Signed-off-by: Zach Puller <zpuller@nvidia.com>
@zpuller
zpuller requested a review from abellina October 16, 2025 15:47
gerashegalov
gerashegalov approved these changes Oct 20, 2025
View reviewed changes

@gerashegalov gerashegalov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zpuller

zpuller commented Oct 20, 2025

Copy link
Copy Markdown
Collaborator Author

build

@zpuller
zpuller merged commit 3956615 into NVIDIA:branch-25.12 Oct 21, 2025
60 checks passed
@zpuller
zpuller deleted the cursor_nvtx branch October 21, 2025 17:32
@sameerz sameerz added the task Work required that improves the product but is not user facing label Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gerashegalov gerashegalov gerashegalov approved these changes
@jihoonson jihoonson Awaiting requested review from jihoonson
@revans2 revans2 Awaiting requested review from revans2
@mythrocks mythrocks Awaiting requested review from mythrocks
@abellina abellina Awaiting requested review from abellina

Assignees

No one assigned

Labels

task Work required that improves the product but is not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zpuller @abellina @gerashegalov @sameerz @nvauto