Add shims layer, Delete command base classes and refactor delta-33x Delete - #13620
Merged
nartal1 merged 2 commits intoOct 20, 2025
Merged
Conversation
nartal1
added
the
task
…elete - Add DeltaCommandShims trait to abstract Spark API differences - Add Delta33xCommandShims implementation for Delta 3.3.x - Add DeleteCommandMetaBase and GpuDeleteCommandBase in common directory - Refactor delta-33x DeleteCommandMeta and GpuDeleteCommand to use base classes - Update delta-33x pom.xml to include delta-33x-40x common directory Tested: - Delta 3.3.0 (buildver=356): BUILD SUCCESS - Delta 4.0.0 (buildver=400): BUILD SUCCESS Signed-off-by: Niranjan Artal <nartal@nvidia.com>
nartal1
force-pushed
the
delta_lake_400_shims_and_delete_cmd
branch
from
October 17, 2025 16:45
bff42ce to
f6f50a2
Compare
nartal1
changed the title
Collaborator
Author
|
build |
razajafri
reviewed
Oct 17, 2025
razajafri
left a comment
razajafri
left a comment
Collaborator
There was a problem hiding this comment.
Did first pass and it looks OK. I will take a look at it again
| * Implements the Delta Probe interface for Delta Lake 4.0.x | ||
| * @note This is instantiated via reflection from ShimLoader | ||
| */ | ||
| class DeltaProbeImpl extends DeltaProbe { |
Collaborator
There was a problem hiding this comment.
This file was added in the previous PR. Nothing to do here, just a comment for reviewers
jihoonson
reviewed
Oct 17, 2025
jihoonson
left a comment
jihoonson
left a comment
Collaborator
There was a problem hiding this comment.
LGTM overall, left a minor comment on the doc.
Collaborator
Author
|
build |
jihoonson
approved these changes
Oct 17, 2025
jihoonson
left a comment
jihoonson
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thanks for updating the docs.
| * | ||
| */ | ||
| type RunSparkSession <: SparkSession | ||
| type ShimSparkSession <: SparkSession |
Comment on lines
+49
to
+50
| * Type alias for the version-specific SparkSession type used for internal operations. | ||
| * This is the SparkSession type used within command execution for operations like: |
10 tasks
revans2
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #13339
Description
In this PR, we mainly refactored delta-33x Delete command to use base classes.
DeltaCommandShimstrait to abstract Spark API differences between Delta 3.3.x and 4.0.xDelta33xCommandShimsimplementation for Delta 3.3.xDeleteCommandMetaBaseandGpuDeleteCommandBasein common directoryDeleteCommandMetaandGpuDeleteCommandto use base classesTesting
Delta 3.3.0 (Scala 2.12, Spark 3.5.6):
BUILD SUCCESS, Ran delta integration tests locally.Delta 4.0.0 (Scala 2.13, Spark 4.0.0):
BUILD SUCCESSChecklists
(Please explain in the PR description how the new code paths are tested, such as names of the new/existing tests that cover them.)