Fix a GBK test failure on DB runtimes[databricks] - #13808
Closed
firestarman wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Collaborator
Author
|
build |
Contributor
Greptile Summary
Confidence Score: 5/5
Sequence DiagramsequenceDiagram
participant Test as "test_csv_read_gbk_encoded_data"
participant Runtime as "Runtime Check"
participant Config as "Spark Config"
participant CSV as "CSV Reader"
Test->>Runtime: "Check is_spark_400_or_later() or is_databricks_runtime()"
alt Spark 4.0+ or Databricks
Runtime->>Config: "Set spark.sql.legacy.javaCharsets=true"
else Earlier Spark version
Runtime->>Config: "Set spark.sql.legacy.javaCharsets=false"
end
Test->>CSV: "Read GBK encoded CSV with config"
CSV->>Test: "Return data"
|
Contributor
There was a problem hiding this comment.
1 file reviewed, no comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
Collaborator
Author
|
build |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #13800
The root cause is missing the check for DB runtimes when specifying the legacy charset config for the CSV read.