Remove low priority iceberg it test cases to save test time [skip ci] - #13922
Merged
Conversation
Signed-off-by: liurenjie1024 <liurenjie2008@gmail.com>
Signed-off-by: liurenjie1024 <liurenjie2008@gmail.com>
Signed-off-by: liurenjie1024 <liurenjie2008@gmail.com>
Contributor
Greptile OverviewGreptile SummaryThis PR addresses timeout issues in Iceberg integration tests by reducing test permutations from an estimated 5.5 hours to 1.5 hours (73% reduction). Key Changes:
Impact Analysis:
Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant PR as PR #13922
participant Tests as Iceberg Integration Tests
participant CI as CI Pipeline
Note over Dev,CI: Problem: Tests timing out after 5+ hours
Dev->>PR: Reduce test permutations
rect rgb(240, 240, 255)
Note over PR,Tests: Parameter Reduction Strategy
PR->>Tests: Remove format_version param (1,2) → use "2" only
PR->>Tests: Remove write_distribution_mode (none,hash,range) → use default
PR->>Tests: Remove fanout param (True,False) → use default
PR->>Tests: Remove reader_type (PERFILE,MULTITHREADED,COALESCING) → use default
end
rect rgb(255, 240, 240)
Note over Tests: Test Reduction Impact
Tests->>Tests: Append: 6x fewer test cases
Tests->>Tests: CTAS: 6-12x fewer test cases
Tests->>Tests: Delete/Update/Merge: 3x fewer test cases
Tests->>Tests: RTAS: 6-12x fewer test cases
Tests->>Tests: Overwrite: 6-12x fewer test cases
end
Tests->>CI: Run reduced test suite
rect rgb(240, 255, 240)
Note over CI: Expected Result
CI->>CI: 5.5h → 1.5h (73% reduction)
CI-->>Dev: Tests complete within timeout
end
|
Collaborator
Author
|
build |
Member
|
also cc @yinqingh to help verify if we need some extra job or we can have this within DEFAULT mode for selected shims, thanks |
Collaborator
Author
|
build |
Collaborator
|
Confirmed with @liurenjie1024 , I will follow up and create a dedicate job to run |
Collaborator
Author
|
Let's wait to see tomorrow's test run. |
This was referenced Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #13881 #13885
Description
We removed a lot of low priority tests cases to reduce iceberg integration tests time. On my local desktop, its time reduced from 5.5h to 1.33h.
Checklists
(Please explain in the PR description how the new code paths are tested, such as names of the new/existing tests that cover them.)