Add null safety guards to the conversion methods in FromIcebergShaded

[res-life]

Improve code: Fix NPE in Iceberg code

[greptile-apps]

Greptile Overview

Greptile Summary

Added null safety guards to all conversion methods in FromIcebergShaded that transform shaded Parquet objects to unshaded versions. The changes prevent potential NPEs when getter methods like columnOrder(), getEncodingStats(), getStatistics(), etc. return null values during Parquet metadata processing.

• Added null checks to 18 unshade overload methods covering all Parquet type conversions
• Each method now returns null when receiving null input, maintaining consistent behavior
• Prevents NPEs in nested unshade calls where getter methods may return nullable values

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The changes are purely defensive, adding null checks to prevent NPEs without altering any business logic. The pattern is consistent across all methods and follows best practices for null safety in conversion utilities
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
iceberg/src/main/scala/com/nvidia/spark/rapids/iceberg/parquet/converter/FromIcebergShaded.scala	5/5	Added defensive null checks to all unshade methods to prevent NPEs when converting Parquet metadata objects

Sequence Diagram

sequenceDiagram
    participant Reader as GpuIcebergParquetReader
    participant Converter as FromIcebergShaded
    participant Parquet as Parquet API
    
    Reader->>Converter: unshade(ShadedMessageType)
    Note over Converter: Check if messageType == null
    alt messageType is null
        Converter-->>Reader: return null
    else messageType is not null
        Converter->>Converter: Process fields
        loop For each field
            Converter->>Converter: unshade(field)
            Note over Converter: Recursive null check
        end
        Converter->>Parquet: Types.buildMessage()
        Parquet-->>Converter: MessageType
        Converter-->>Reader: MessageType
    end
    
    Reader->>Converter: unshade(ShadedColumnChunkMetaData)
    Note over Converter: Check if metadata == null
    Converter->>Converter: unshade(getPath)
    Note over Converter: Nested null check for path
    Converter->>Converter: unshade(getEncodingStats)
    Note over Converter: Nested null check for stats
    Converter->>Converter: unshade(getStatistics)
    Note over Converter: Nested null check for statistics
    Converter->>Parquet: ColumnChunkMetaData.get(...)
    Parquet-->>Reader: ColumnChunkMetaData

Loading

[greptile-apps]

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[res-life]

build

[res-life]

build