Skip to content

Refactor regex group parsing and explicitly reject unsupported group types #15331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igorpeshansky merged 8 commits into from
Jul 23, 2026
Merged

Refactor regex group parsing and explicitly reject unsupported group types #15331

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5d82392
Refactor RegexGroup handling in RegexParser and related classes
igorpeshansky Jul 21, 2026
46447ea
Parse and handle independent, named, and lookbehind groups
igorpeshansky Jul 21, 2026
998ba54
Update compatibility documentation to explicitly list unsupported reg…
igorpeshansky Jul 21, 2026
53e957f
Address feedback and fix mismatched parentheses in the test
igorpeshansky Jul 22, 2026
1513db0
License update.
igorpeshansky Jul 22, 2026
e67736c
Resolve Scala misunderstanding.
igorpeshansky Jul 22, 2026
2672777
Fix mistaken test assumption.
igorpeshansky Jul 22, 2026
c8554ce
Merge branch 'main' into regex-transpiler-refactor
igorpeshansky Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/compatibility.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,9 @@ The following regular expression patterns are not yet supported on the GPU and w
- Possessive quantifiers, such as `a*+`
- Character classes that use union, intersection, or subtraction semantics, such as `[a-d[m-p]]`, `[a-z&&[def]]`,
or `[a-z&&[^bc]]`
- Lookahead/lookbehind groups: `(?=a)`, `(?!a)`, `(?<=a)`, `(?<!a)`
- Independent groups: `(?>a)`
- Named capture groups: `(?<n>a)`
- Empty groups: `()`
- Empty pattern: `""`

Expand Down
4 changes: 2 additions & 2 deletions integration_tests/src/main/python/regexp_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1042,9 +1042,9 @@ def test_rlike_fallback_possessive_quantifier():
conf=_regexp_conf)

@allow_non_gpu('ProjectExec', 'RLike')
def test_rlike_fallback_lookaheads():
def test_rlike_fallback_lookarounds_independent_named():
gen = mk_str_gen('(\u20ac|\\w){0,3}a[|b*.$\r\n]{0,2}c\\w{0,3}')
for pattern in ['a(?=a*)', 'a(?!a*)']:
for pattern in ['a(?=a*)', 'a(?!a*)', 'a(?<=a)', 'a(?<!a)', 'a(?>a*)', 'a(?<n>a*)']:
assert_gpu_fallback_collect(
lambda spark, pattern=pattern: unary_op_df(spark, gen).selectExpr(
f'a rlike "{pattern}"'),
Expand Down
Loading
Loading