Fix OSS Delta RTAS on Spark 4.x+ [databricks] - #15411
Merged
Merged
Conversation
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Contributor
Greptile SummaryThe PR enables GPU execution of Spark 4 atomic Delta RTAS operations.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Sequence DiagramsequenceDiagram
participant Spark as Spark 4 Planner
participant Catalog as GPU Delta Catalog
participant Provider as Delta Provider
participant Exec as GPU Overwrite Exec
participant Commit as Staged Delta Commit
Spark->>Catalog: Stage CREATE OR REPLACE TABLE
Catalog-->>Spark: Staged table with TRUNCATE capability
Spark->>Catalog: Build truncate write
Spark->>Provider: Tag OverwriteByExpressionExecV1
Provider-->>Spark: GPU-compatible staged table
Spark->>Exec: Convert and execute overwrite
Exec->>Catalog: Capture AS SELECT data
Spark->>Commit: Commit staged changes
Commit-->>Spark: Replaced Delta table
Reviews (4): Last reviewed commit: "Merge branch 'release/26.08' into rtas_d..." | Re-trigger Greptile |
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Collaborator
Author
|
build |
1 similar comment
Collaborator
Author
|
build |
Collaborator
Author
|
build |
8 tasks
nvliyuan
added a commit
that referenced
this pull request
Jul 30, 2026
Resolves the latest merge conflicts in #15412 after #15423 merged. ### Description Merge the current `release/26.08` head into the current `main` head. The initial conflicts were the root and Scala 2.13 project versions. Both were resolved by retaining main's `26.10.0-SNAPSHOT` version instead of the release branch's `26.08.0-SNAPSHOT` version. The branch was refreshed again after additional PRs landed on `release/26.08`. The current diff includes all release updates added after #15423, including: - #15413 — preserve Spark 4.2 BroadcastHashJoin `isSkewJoin` - #15422 — fix Iceberg REST S3 path regression coverage - #15368 — OSS Delta deletion-vector updates - #15411 — fix OSS Delta RTAS on Spark 4.x+ - #15416 — match Spark 4.2 `date_trunc` overflow behavior ### Checklists Documentation - [ ] Updated for new or modified user-facing features or behaviors - [x] No user-facing change Testing - [ ] Added or modified tests to cover new code paths - [x] Covered by existing tests (The included release commits retain their original tests.) - [ ] Not required Performance - [ ] Tests ran and results are added in the PR description - [ ] Issue filed with a link in the PR description - [x] Not required ### Validation - `git diff --check` - Parsed both initially resolved POM files as XML - `python3 -m py_compile` for the modified Iceberg, Delta, and date-time integration tests IMPORTANT: Merge this PR using **Create a merge commit** so the release commit ancestry is preserved and #15412 can close automatically. --------- Signed-off-by: Sameer Raheja <sraheja@.nvidia.com> Signed-off-by: Rahul Prabhu <raprabhu@nvidia.com> Signed-off-by: Chong Gao <chongg@nvidia.com> Signed-off-by: Firestarman <firestarmanllc@gmail.com> Signed-off-by: Ray Liu <liurenjie2008@gmail.com> Signed-off-by: liyuan <yuali@nvidia.com> Signed-off-by: Jihoon Son <ghoonson@gmail.com> Signed-off-by: Niranjan Artal <nartal@nvidia.com> Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com> Co-authored-by: Sameer Raheja <sraheja@.nvidia.com> Co-authored-by: Gary Shen <gashen@nvidia.com> Co-authored-by: Rahul Prabhu <100436830+sdrp713@users.noreply.github.com> Co-authored-by: Chong Gao <chongg@nvidia.com> Co-authored-by: Chong Gao <res_life@163.com> Co-authored-by: Liangcai Li <firestarmanllc@gmail.com> Co-authored-by: Renjie Liu <liurenjie2008@gmail.com> Co-authored-by: Jihoon Son <ghoonson@gmail.com> Co-authored-by: Niranjan Artal <50492963+nartal1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15394
Description
On OSS Spark 4.0 with Delta Lake 4.0,
CREATE OR REPLACE TABLE ... USING DELTA AS SELECT ...succeeds on CPU but fails on GPU with:Spark 4 plans RTAS as an unconditional
OverwriteByExpression. Its table capability check therefore requires the staged table to supportTRUNCATE.The RAPIDS staged Delta table advertised only
V1_BATCH_WRITE, and its write builder did not implementSupportsTruncate. In addition, the Delta provider'sOverwriteByExpressionExecV1handling recognized regularDeltaTableV2tables but not the RAPIDS staged Delta table used by atomic RTAS.In this PR:
TRUNCATEto the capabilities advertised byGpuStagedDeltaTableV2.SupportsTruncatein the staged Delta V1 write builder.OverwriteByExpressionExecV1for RAPIDS staged Delta tables toGpuOverwriteByExpressionExecV1.DeltaTableV2tables and continues to reject unrelated table implementations.Testing
OSS Spark 4.0 / Delta Lake 4.0
Focused integration test:
Result:
1 passed, 39635 deselected.Broader focused RTAS selection:
Result:
3 passed, 1 skipped, 39632 deselected.Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance