[fast-ut] [reduced-it] [SkipRecovery] Restore Delta REORG coverage on Spark 4.1.1+ [databricks] - #15480
[fast-ut] [reduced-it] [SkipRecovery] Restore Delta REORG coverage on Spark 4.1.1+ [databricks]#15480wjxiz1992 wants to merge 1 commit into
Conversation
Signed-off-by: Allen Xu <allxu@nvidia.com>
Greptile SummaryNarrows the Delta REORG regression skip so the deletion-vector materialization scan-split test runs on supported Spark 4.1.1+ profiles while remaining skipped on Spark 4.0.1 through 4.0.x.
Confidence Score: 5/5The PR appears safe to merge because the narrowed skip aligns with the repository’s supported Spark and Delta profile boundaries. The existing version helper is available, Spark 4.0.x profiles remain excluded from the incompatible REORG path, Spark 4.1.1 profiles use Delta 4.1.0, and Databricks execution remains independently skipped. Important Files Changed
Reviews (1): Last reviewed commit: "test: restore Delta REORG coverage on Sp..." | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
This PR adjusts Spark-version gating in the Delta Lake integration tests to restore coverage for the Delta REORG regression guard on supported Spark 4.1.1+ profiles, while keeping the guard for affected Spark 4.0.1–4.0.x runtimes.
Changes:
- Adds
is_spark_411_or_laterusage indelta_lake_test.pyto refine the REORG skip condition. - Updates the skip reason text to clarify the dependency on Delta 4.1.0 availability in supported Spark 4.1.1+ profiles.
Suppressed comments (1)
integration_tests/src/main/python/delta_lake_test.py:827
- The new skip condition (
is_spark_401_or_later() and not is_spark_411_or_later()) also skips Spark 4.1.0, not just Spark 4.0.1 through 4.0.x as described in the PR. Sincespark_session.pyalready exposesis_spark_40x(), using it would match the stated intent and avoid unintentionally skipping 4.1.0 environments.
@pytest.mark.skipif(is_spark_401_or_later() and not is_spark_411_or_later(),
| from spark_session import is_spark_411_or_later | ||
| from spark_session import with_cpu_session, with_gpu_session, is_databricks_runtime, \ | ||
| is_spark_320_or_later, is_spark_340_or_later, supports_delta_lake_deletion_vectors, is_spark_401_or_later, \ | ||
| is_before_spark_353, is_databricks173_or_later |
JaCoCo sql-plugin line coverage: not measurable locally — the recovered Spark 4.0/4.1 classfiles do not match the shim350 nightly aggregate
Contributes to delta-io/delta#5690.
Description
Narrow the Delta REORG regression guard from every Spark 4.0.1+ runtime to
Spark 4.0.1 through 4.0.x. This restores the existing deletion-vector
materialization scan-split test on supported Spark 4.1.1+ profiles, where
Delta 4.1.0 contains the upstream fix.
The guard is intentionally retained for Spark 4.0.1 through 4.0.x because
Delta 4.0.0 still reproduces the upstream binary incompatibility during CPU
table setup. The target remains independently skipped on Databricks, so no
Databricks execution claim is made.
Validation
py_compile,git diff --check, and current exemption scan passed.1 skipped, 250 deselected;ParquetToSparkSchemaConverterfive-argumentNoSuchMethodError.BUILD SUCCESS, 14/14 reactor modules;1 passed, 250 deselected;FileSourceScanExec will run on GPU.BUILD SUCCESS, 14/14 reactor modules;1 passed, 250 deselected;delta_lake_test.py:248 passed, 3 skipped, 0 failed;tests=251, errors=0, failures=0, skipped=3; target passed;FileSourceScanExec will run on GPUin exact and full-file runs.0 must-fix, 0 should-fix, 0 suggestions.Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance