Conversation
Greptile SummaryThis PR adds an Atlas inference example demonstrating both a manual forward-pass approach and the
|
| Filename | Overview |
|---|---|
| earth2studio/models/nn/atlas.py | Separates the physicsnemo import into its own try/except block so that failures in the secondary optional dependencies (natten, einops, timm, torch_harmonics) no longer silently cause PhysicsNeMoModule to fall back to object, which previously broke checkpoint loading with a misleading error. |
| examples/02_medium_range/06_atlas_inference.py | New Atlas inference example demonstrating both a manual forward pass and the run.deterministic workflow. License header, structure, and plot are correct, but the stated ~14-minute runtime exceeds the 10-minute example rule, one RST section underline is too short, and a trailing-whitespace character on line 75 would fail the pre-commit hook. |
| pyproject.toml | Adds <3.14 upper bound to the Python version constraint to block Python 3.14 until torch.compile (a natten dependency) supports it; includes an explanatory inline comment. |
Reviews (1): Last reviewed commit: "Add atlas example" | Re-trigger Greptile
|
/blossom-ci |
|
/blossom-ci |
| # deterministic, but we use this workflow for simplicity since we're just | ||
| # generating a single ensemble member. | ||
|
|
||
| # %% |
There was a problem hiding this comment.
imo maybe dont need this code block in the recipe to keep it more concise
There was a problem hiding this comment.
But if you think its really needed, can leave it.
| # The deterministic workflow handles this automatically via the model's | ||
| # ``input_coords`` definition. | ||
| # | ||
| # .. note:: |
There was a problem hiding this comment.
Consider making this a warning instead.
| description = "Open-source deep-learning framework for exploring, building and deploying AI weather/climate workflows." | ||
| readme = "README.md" | ||
| requires-python = ">=3.11" | ||
| requires-python = ">=3.11,<3.14" #<3.14 until PyT adds support for torch.compile with it, blocker for natten |
There was a problem hiding this comment.
Can't do this just for natten / atlas.
You should be able to restrict just natten to below a given python version I think...
But regardless, we suggest python 3.12 in the install docs.
| @@ -0,0 +1,218 @@ | |||
| # SPDX-FileCopyrightText: Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. | |||
There was a problem hiding this comment.
Haven't ran this yet, but whats the run time / GPU requirement?
Earth2Studio Pull Request
Description
Adds an example (~5min runtime) demoing the two ways of doing Atlas inference. Also reorganizes some imports in
nn/atlas.pyfor better protection against confusing errors. Previouslyphysicsnemo.Modulewas imported in the same try block asnatten,einops,timm, andtorch_harmonics. If any one of those secondary deps fails to import,PhysicsNeMoModulefalls back toobject, so classes likeNattenCombineDiTdon't inheritModule._override_argsand can't load a checkpoint (which points the user away from the actual issue). Fixed now with different import order.Checklist
Dependencies