Skip to content

feat: Add tray location for switch machine powershelf from RMS#807

Open
vinodchitraliNVIDIA wants to merge 1 commit intoNVIDIA:mainfrom
vinodchitraliNVIDIA:vc/physical
Open

feat: Add tray location for switch machine powershelf from RMS#807
vinodchitraliNVIDIA wants to merge 1 commit intoNVIDIA:mainfrom
vinodchitraliNVIDIA:vc/physical

Conversation

@vinodchitraliNVIDIA
Copy link
Copy Markdown
Contributor

@vinodchitraliNVIDIA vinodchitraliNVIDIA commented Apr 3, 2026

Added location field to Machine, Switch, PowerShelf, and Rack — dedicated VARCHAR(256) columns in DB tables

Site explorer wires location from config to entity from RMS

Description

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Related Issues (Optional)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

@vinodchitraliNVIDIA vinodchitraliNVIDIA requested a review from a team as a code owner April 3, 2026 20:35
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

🔐 TruffleHog Secret Scan

No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

🕐 Last updated: 2026-04-03 20:37:17 UTC | Commit: 2248bb7

@Matthias247
Copy link
Copy Markdown
Contributor

we should clarify what location is. Because by just looking at the code, its unclear whether this is a slot_id or something like "datahall 5 row 10 place 4".
Ideally we give it a more descriptive name, based on what we want to do with it. E.g. if we want to check traying ordering against what is encoded in expected-machines, it should probably be the slot-id/tray-index/etc

@zhaozhongn
Copy link
Copy Markdown

Core will not get these data via RMS only. In the long-term it will be via the component manager API interface so ANY plugins to Core could be able to provide such info. In the short-term, if it is not done this way, it will be by Core accessing NVOS and BMC directly as happened in endpoint exploration today for other similar info.

Added location field to Machine, Switch, PowerShelf, and Rack — dedicated VARCHAR(256) columns in DB tables

Site explorer wires location from config to entity from RMS

Signed-off-by: Vinod Chitrali <vchitrali@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants