chore: drop EthernetVirtualizerWithNvue override from carbide-api -> dpu-agent#838
Open
chet wants to merge 1 commit intoNVIDIA:mainfrom
Open
chore: drop EthernetVirtualizerWithNvue override from carbide-api -> dpu-agent#838chet wants to merge 1 commit intoNVIDIA:mainfrom
chet wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-04-07 17:52:37 UTC | Commit: f69a029 |
…dpu-agent And now we can drop this. There was somewhat of a backwards compatibility concern in between releases, because if `carbide-api` got bumped and started passing down `EthernetVirtualizer`, and `carbide-dpu-agent` hand't been updated yet, it would reject config updates for <= 10 minutes while we waited for the next "update `carbide-dpu-agent` cron job" to fire off. The plan was to wait on this for the next release, but since the release schedule got modified due to a shortened QA cycle, I can actually do this now. Signed-off-by: Chet Nichols III <chetn@nvidia.com>
chet
force-pushed
the
drop_agent_etv_hack
branch
from
f69a029 to
88b9ea9
Compare
DrewBloechl
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
And now we can drop this. There was somewhat of a backwards compatibility concern in between releases, because if
carbide-apigot bumped and started passing downEthernetVirtualizer, andcarbide-dpu-agenthand't been updated yet, it would reject config updates for <= 10 minutes while we waited for the next "updatecarbide-dpu-agentcron job" to fire off. The plan was to wait on this for the next release, but since the release schedule got modified due to a shortened QA cycle, I can actually do this now.Signed-off-by: Chet Nichols III chetn@nvidia.com
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes