Fix submit_kernel non-zero exit for failed submissions - #18
Merged
alessiodevoto merged 1 commit intoJul 10, 2026
Merged
Conversation
Collaborator
|
Hi @fallintoplace, could you fix the body of your PR that is not legible as is now? Also, we have updated the contributing guidelines, so please rebase on main and make sure to follow those from the next commit! Thanks 🙂 |
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
fallintoplace
force-pushed
the
fix/exit-on-submission-failure
branch
from
July 9, 2026 16:59
2fd4339 to
f435dfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Make
submit_kernel.pyreturn a non-zero exit code when a Kaggle submission or evaluation fails, so CI and agents do not treat a broken submission as a successful run.The root cause was that the script only exited non-zero when kernel execution itself failed. Submission failures from
competition_submit_codeor non-completeevaluation results were printed, but the process still returned success.This change keeps track of an overall success state across kernel execution, submission acceptance, and evaluation polling, then exits with status
1whenever any of those stages fails.Checklist
uv run pytest)git commit -sSPDX-FileCopyrightText/SPDX-License-Identifier) is included on new non-markdown code filesCONTRIBUTING.md)KAGGLE_API_TOKEN(or another env var) and no account artifacts are committedNot applicable for this PR:
claude plugin validate .was not required.Validation
uv run pytest