Skip to content

NanoHTTPD class no longer needs to be abstract#468

Open
jh3141 wants to merge 1 commit intoNanoHttpd:masterfrom
jh3141:feature/nanohttpd-concrete
Open

NanoHTTPD class no longer needs to be abstract#468
jh3141 wants to merge 1 commit intoNanoHttpd:masterfrom
jh3141:feature/nanohttpd-concrete

Conversation

@jh3141
Copy link
Copy Markdown
Contributor

@jh3141 jh3141 commented Nov 25, 2017

As there is no longer any need to override the handle method (because a pluggable IHandler instance can be used instead) there is no need for NanoHTTPD to be abstract any more.

As there is no longer any need to override the handle method (because a pluggable IHandler instance can be used instead) there is no need for NanoHTTPD to be abstract any more.
@LordFokas LordFokas self-requested a review January 3, 2018 17:52
@LordFokas
Copy link
Copy Markdown
Member

I'll have to look at this later. I either forgot that OR there's a reason I did it. But one of my targets with 3.0 was to remove the need to extend the httpd/wsd core classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants