Skip to content

Clarify temperature and humidity location (by variable names)#343

Merged
RDaxini merged 4 commits into
development_0800from
variablenames
Jun 2, 2026
Merged

Clarify temperature and humidity location (by variable names)#343
RDaxini merged 4 commits into
development_0800from
variablenames

Conversation

@RDaxini

@RDaxini RDaxini commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Describe your changes

add some clarity eg between module/ambient temperature, ambient/surface humidity
miscellaneous notebook cleanups

Issue ticket number and link

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • Code changes are covered by tests.
  • Code changes have been evaluated for compatibility/integration with Scenario analysis (for future PRs)
  • Code changes have been evaluated for compatibility/integration with geospatial autotemplating (for future PRs)
  • New functions added to init.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • What's new changelog has been updated in the docs

@RDaxini RDaxini changed the base branch from main to development_0800 June 1, 2026 19:42
@RDaxini RDaxini added Clarity for users Things that help the user implement the code more easily. api Pull requests that update the core functions and classes labels Jun 1, 2026
@RDaxini RDaxini added this to the v0.8.0 milestone Jun 1, 2026
@codecov-commenter

codecov-commenter commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (development_0800@4d72170). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pvdeg/humidity.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##             development_0800     #343   +/-   ##
===================================================
  Coverage                    ?   76.36%           
===================================================
  Files                       ?       41           
  Lines                       ?     5357           
  Branches                    ?        0           
===================================================
  Hits                        ?     4091           
  Misses                      ?     1266           
  Partials                    ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RDaxini

RDaxini commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator Author

merging since test failure is unelated to the changes made in this pr

@RDaxini RDaxini merged commit 89e204b into development_0800 Jun 2, 2026
23 of 26 checks passed
@RDaxini RDaxini deleted the variablenames branch June 2, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Pull requests that update the core functions and classes Clarity for users Things that help the user implement the code more easily. notebooks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants