Fix comstock workflow generator version bug#487
Open
rajeee wants to merge 8 commits into
Open
Conversation
Minimum allowed line rate is |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with the ComStock WorkflowGenerator version by adding the missing definition for version 2024.07.18 and updating error messages to list available versions.
- Added a mapping for commercial_v2024_07_18 in the version info dictionary
- Updated error messages to convert version keys to a list for clarity
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| buildstockbatch/workflow_generator/init.py | Added missing mapping for commercial_v2024_07_18 version info |
| buildstockbatch/base.py | Updated error messages to display available version keys clearly |
Comments suppressed due to low confidence (3)
buildstockbatch/base.py:839
- Including the available versions in the error message is helpful; ensure that this format is consistent with similar validations to avoid potential confusion.
raise ValidationError( ... f"Available versions: {list(workflow_generator.version2info[wg_type].keys())}" ... )
buildstockbatch/workflow_generator/init.py:52
- Ensure that 'commercial_v2024_07_18' is correctly imported and its version attribute is unique, helping avoid potential key conflicts in the version mapping.
commercial_v2024_07_18.__version__: commercial_v2024_07_18.version_info,
buildstockbatch/base.py:91
- Converting the available version keys to a list improves clarity; confirm that this format meets end–user expectations and maintains consistency with similar error messages.
f"Available versions are {list(workflow_generator.version2GeneratorClass[generator_type].keys())}"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #486.
Pull Request Description
Fix the missing ComStock WokflowGenerator version 2024.07.18 definition.
Checklist
Not all may apply
minimum_coveragein.github/workflows/coverage.ymlas necessary.