Skip to content

Hand picked changes for kestrel run#516

Merged
asparke2 merged 4 commits into
developfrom
enhancements
Oct 21, 2025
Merged

Hand picked changes for kestrel run#516
asparke2 merged 4 commits into
developfrom
enhancements

Conversation

@rajeee

@rajeee rajeee commented Aug 21, 2025

Copy link
Copy Markdown
Collaborator

Fixes # .

Pull Request Description

These changes are hand picked from #512. Only changes that minimally deviates from develop is selected and postprocessing workflow change related commits are ignored.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/coverage.yml as necessary.
  • All other unit and integration tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run on Kestrel to make sure it all works if you made changes that will affect Kestrel
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@rajeee rajeee requested a review from asparke2 August 22, 2025 01:39
@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Complexity Health
. 84% 0
cloud 86% 0
sampler 58% 0
test 93% 0
workflow_generator 95% 0
workflow_generator.commercial 100% 0
workflow_generator.commercial.latest 73% 0
workflow_generator.commercial.v2024_07_18 73% 0
workflow_generator.residential 100% 0
workflow_generator.residential.latest 93% 0
workflow_generator.residential.latest.tests 100% 0
workflow_generator.residential.v2024_07_18 91% 0
workflow_generator.residential.v2024_07_18.tests 99% 0
workflow_generator.residential.v2024_07_19 70% 0
workflow_generator.residential.v2024_07_19.tests 99% 0
workflow_generator.residential.v2024_07_20 70% 0
workflow_generator.residential.v2024_07_20.tests 100% 0
workflow_generator.residential.v2025_01_29 70% 0
workflow_generator.residential.v2025_01_29.tests 100% 0
workflow_generator.residential.v2025_02_25 70% 0
workflow_generator.residential.v2025_02_25.tests 100% 0
Summary 87% (6028 / 6939) 0

Minimum allowed line rate is 33%

@asparke2 asparke2 merged commit fe513ce into develop Oct 21, 2025
4 checks passed
shorowit added a commit to NatLabRockies/resstock that referenced this pull request Oct 23, 2025
shorowit added a commit to NatLabRockies/resstock that referenced this pull request Oct 23, 2025
"include_annual_emissions": True,
"include_annual_emission_fuels": True,
"include_annual_emission_end_uses": True,
"include_annual_emission_end_uses": False,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajeee @asparke2 Is this default value change necessary? This breaks a couple resstock CI tests (since the current residential yml schema does not support toggling including annual outputs or not).

This may be our workaround, but it's probably not the preferred path forward.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it make the most sense to expose all the include_annual_foo variables as arguments in the yaml? That way they can be turned on or off as needed, as is the case for the include_timeseries_foo variables.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. But more work.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but might save work in the long run if it avoids future situations like this.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to expose all the include_annual_foo variables as arguments here.

joseph-robertson added a commit to NatLabRockies/resstock that referenced this pull request Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants