Hand picked changes for kestrel run#516
Merged
Merged
Conversation
Minimum allowed line rate is |
asparke2
approved these changes
Oct 21, 2025
shorowit
added a commit
to NatLabRockies/resstock
that referenced
this pull request
Oct 23, 2025
shorowit
added a commit
to NatLabRockies/resstock
that referenced
this pull request
Oct 23, 2025
| "include_annual_emissions": True, | ||
| "include_annual_emission_fuels": True, | ||
| "include_annual_emission_end_uses": True, | ||
| "include_annual_emission_end_uses": False, |
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Wouldn't it make the most sense to expose all the include_annual_foo variables as arguments in the yaml? That way they can be turned on or off as needed, as is the case for the include_timeseries_foo variables.
Contributor
There was a problem hiding this comment.
Sure. But more work.
Contributor
There was a problem hiding this comment.
Right, but might save work in the long run if it avoids future situations like this.
Contributor
There was a problem hiding this comment.
We decided to expose all the include_annual_foo variables as arguments here.
joseph-robertson
added a commit
to NatLabRockies/resstock
that referenced
this pull request
Oct 25, 2025
Latest OS-HPXML: workaround for NatLabRockies/buildstockbatch#516
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Pull Request Description
These changes are hand picked from #512. Only changes that minimally deviates from develop is selected and postprocessing workflow change related commits are ignored.
Checklist
Not all may apply
minimum_coveragein.github/workflows/coverage.ymlas necessary.