Skip to content

Fix compile on UE 5.8: FJsonObject keys are now FSharedString #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
javidmedina wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix compile on UE 5.8: FJsonObject keys are now FSharedString #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion UnrealClaude/Source/UnrealClaude/Private/AnimationBlueprintUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,7 +927,7 @@ TSharedPtr<FJsonObject> FAnimationBlueprintUtils::ExecuteBatchOperations(
{
for (const auto& Pair : (*BindingsObj)->Values)
{
Bindings.Add(Pair.Key, Pair.Value->AsString());
Bindings.Add(FString(*Pair.Key), Pair.Value->AsString());
}
}
bOpSuccess = SetStateBlendSpace(
Expand Down
4 changes: 2 additions & 2 deletions UnrealClaude/Source/UnrealClaude/Private/MCP/MCPToolBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,9 @@ class FMCPToolBase : public IMCPTool
TArray<FString> Unknown;
for (const auto& Pair : Params->Values)
{
if (!Known.Contains(Pair.Key))
if (!Known.Contains(FString(*Pair.Key)))
{
Unknown.Add(Pair.Key);
Unknown.Add(FString(*Pair.Key));
}
}
return Unknown;
Expand Down
2 changes: 1 addition & 1 deletion UnrealClaude/Source/UnrealClaude/Private/MCP/Tools/MCPTool_AnimBlueprintModify.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,7 +775,7 @@ FMCPToolResult FMCPTool_AnimBlueprintModify::HandleSetStateAnimation(const FStri
{
for (const auto& Pair : (*BindingsObj)->Values)
{
Bindings.Add(Pair.Key, Pair.Value->AsString());
Bindings.Add(FString(*Pair.Key), Pair.Value->AsString());
}
}
bSuccess = FAnimationBlueprintUtils::SetStateBlendSpace(
Expand Down
4 changes: 2 additions & 2 deletions UnrealClaude/Source/UnrealClaude/Private/MCP/Tools/MCPTool_BlueprintModify.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ FMCPToolResult FMCPTool_BlueprintModify::ExecuteAddNode(const TSharedRef<FJsonOb
if (PinValue.Value->TryGetString(PinValueStr))
{
FString PinError;
FBlueprintUtils::SetPinDefaultValue(Graph, NodeId, PinValue.Key, PinValueStr, PinError);
FBlueprintUtils::SetPinDefaultValue(Graph, NodeId, FString(*PinValue.Key), PinValueStr, PinError);
}
}
}
Expand Down Expand Up @@ -545,7 +545,7 @@ bool FMCPTool_BlueprintModify::CreateNodesFromSpec(
if (PinValue.Value->TryGetString(PinValueStr))
{
FString PinError;
FBlueprintUtils::SetPinDefaultValue(Graph, NodeId, PinValue.Key, PinValueStr, PinError);
FBlueprintUtils::SetPinDefaultValue(Graph, NodeId, FString(*PinValue.Key), PinValueStr, PinError);
}
}
}
Expand Down
6 changes: 3 additions & 3 deletions UnrealClaude/Source/UnrealClaude/Private/MCP/Tools/MCPTool_Material.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ bool FMCPTool_Material::ApplyParametersFromJson(UMaterialInstanceConstant* MatIn
if (Pair.Value->TryGetNumber(Value))
{
FString Error;
if (!SetScalarParameter(MatInst, Pair.Key, static_cast<float>(Value), Error))
if (!SetScalarParameter(MatInst, FString(*Pair.Key), static_cast<float>(Value), Error))
{
Errors.Add(Error);
bAllSuccess = false;
Expand All @@ -566,7 +566,7 @@ bool FMCPTool_Material::ApplyParametersFromJson(UMaterialInstanceConstant* MatIn
(*ColorObj)->TryGetNumberField(TEXT("a"), Color.A);

FString Error;
if (!SetVectorParameter(MatInst, Pair.Key, Color, Error))
if (!SetVectorParameter(MatInst, FString(*Pair.Key), Color, Error))
{
Errors.Add(Error);
bAllSuccess = false;
Expand All @@ -584,7 +584,7 @@ bool FMCPTool_Material::ApplyParametersFromJson(UMaterialInstanceConstant* MatIn
if (Pair.Value->TryGetString(TexturePath))
{
FString Error;
if (!SetTextureParameter(MatInst, Pair.Key, TexturePath, Error))
if (!SetTextureParameter(MatInst, FString(*Pair.Key), TexturePath, Error))
{
Errors.Add(Error);
bAllSuccess = false;
Expand Down
2 changes: 1 addition & 1 deletion UnrealClaude/Source/UnrealClaude/Private/MCP/Tools/MCPTool_SetProperty.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ bool FMCPTool_SetProperty::SetStructPropertyValue(FStructProperty* StructProp, v
for (const auto& Pair : (*ObjVal)->Values)
{
if (!bFirst) TextRepresentation += TEXT(",");
TextRepresentation += Pair.Key.ToUpper() + TEXT("=");
TextRepresentation += FString(*Pair.Key).ToUpper() + TEXT("=");

double NumVal;
FString StrVal;
Expand Down