refactor: remove deprecated setFileTypeIfEmpty method#1418
Draft
ianpgifford wants to merge 1 commit into
Draft
Conversation
Collaborator
Author
|
I could not find any instances where the String[] overload of the function was in use, so no changes are necessary here or elsewhere. |
Collaborator
|
I believe we were not planning to remove depreacted functions until the next major release. Is that right @jpdahlke |
Collaborator
Author
According to the ticket, this is not supposed to be removed until Emissary 9, but I figured the branch and/or PR can stand until then. Wasn't sure how long that would be, though. This was done before you had sent me the approved work chart so also feel free to close this if it's out of scope. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
To test: