Skip to content

refactor: remove deprecated setFileTypeIfEmpty method#1418

Draft
ianpgifford wants to merge 1 commit into
NationalSecurityAgency:mainfrom
ianpgifford:refactor-remove-deprecated-setFileTypeIfEmpty
Draft

refactor: remove deprecated setFileTypeIfEmpty method#1418
ianpgifford wants to merge 1 commit into
NationalSecurityAgency:mainfrom
ianpgifford:refactor-remove-deprecated-setFileTypeIfEmpty

Conversation

@ianpgifford

Copy link
Copy Markdown
Collaborator

Changes:

  • Removed deprecated setFileTypeIfEmpty overload and move its code into the remaining implementation of the method
  • Remove tests for removed function
    To test:
  • Tests pass

@ianpgifford ianpgifford marked this pull request as ready for review June 2, 2026 15:08
@ianpgifford

Copy link
Copy Markdown
Collaborator Author

I could not find any instances where the String[] overload of the function was in use, so no changes are necessary here or elsewhere.

@cfkoehler

Copy link
Copy Markdown
Collaborator

I believe we were not planning to remove depreacted functions until the next major release. Is that right @jpdahlke

@ianpgifford

Copy link
Copy Markdown
Collaborator Author

I believe we were not planning to remove depreacted functions until the next major release. Is that right @jpdahlke

According to the ticket, this is not supposed to be removed until Emissary 9, but I figured the branch and/or PR can stand until then. Wasn't sure how long that would be, though. This was done before you had sent me the approved work chart so also feel free to close this if it's out of scope.

@ianpgifford ianpgifford marked this pull request as draft June 8, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants