Crossref support#110
Open
Engerrs wants to merge 48 commits into
Open
Conversation
alycejenni
requested changes
Oct 24, 2024
alycejenni
left a comment
alycejenni
left a comment
Member
There was a problem hiding this comment.
Hi @Engerrs, thank you for your PR! This is something we've considered adding in the past, but since we don't use crossref ourselves it hasn't been a priority.
I'd like to request a few changes:
- please make sure you read the contributing guidelines, especially for code style and commit messages (for future commits)
- requirements need to go in
pyproject.toml, notrequirements.txt - this is quite a significant new feature, so we need some test coverage for it
standardise format, change name of tests file
new workflow to check commit format and code style against pre-commit config
update pre-commit repo versions and switch black to ruff
version specifier is deprecated
accidentally downgraded it automatically
F401 returns linting errors as well as auto-fixes, so this disables the errors and just applies the fixes
docformatter currently can't read from pyproject.toml without tomli
auto reformat with ruff/docformatter/prettier after config changes
Contributor
Author
|
Hi @alycejenni , ok, I will adjust the code and write test for this. |
Weekly release 2024-11-04
tests workflow file was renamed
Gets rid of the old initdb command and introduces an initialisation migration script. Enables compatibility with CKAN 2.11. BREAKING CHANGE: switch to alembic migration scripts Closes: NaturalHistoryMuseum#118
Weekly release 2025-03-17
- avoid using fixes that don't work for python 3.8 (our current version) - ignore recommended ruff formatter conflicts - ignore more docstring rules
Weekly release 2025-06-09
Weekly release 2025-08-11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi guys
Added support for Crossref.
Out of the box it shouldn't break any original behavior, but also add an ability to use Crossref instead of DataCite.
Please review this and let me know if any adjustments are needed to be done.
Also updated the DB table initialization to use more modern CKAN way using migrations.