Skip to content

Weekly release 2025-06-16 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alycejenni merged 2 commits into from
Jun 16, 2025
Merged

Weekly release 2025-06-16 #67

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58514ba
fix: try and convert page param to int
alycejenni Jun 10, 2025
6d3773e
merge: #66 from ginger/int-page
alycejenni Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ckanext/gallery/plugins/gallery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,10 @@ def setup_template_variables(self, context, data_dict):
"""
records_per_page = toolkit.config.get('ckanext.gallery.records_per_page', 32)
current_page = toolkit.request.params.get('page', 1)
try:
current_page = int(current_page)
except ValueError:
current_page = 1
image_list = []

# Get list of datastore fields and format into a dict, ready for a form
Expand Down Expand Up @@ -163,7 +167,7 @@ def setup_template_variables(self, context, data_dict):
# Load the images
# Only try and load images, if an image field has been selected
if image_field and image_plugin:
offset = (int(current_page) - 1) * records_per_page
offset = (current_page - 1) * records_per_page
# We only want to get records that have both the image field populated
# So add filters to the datastore search params
filters = self._get_request_filters()
Expand Down
Loading