Skip to content

fix return type of zbar_symbol_get_orientation#151

Open
infacc wants to merge 1 commit into
NaturalHistoryMuseum:masterfrom
infacc:master
Open

fix return type of zbar_symbol_get_orientation#151
infacc wants to merge 1 commit into
NaturalHistoryMuseum:masterfrom
infacc:master

Conversation

@infacc

@infacc infacc commented Aug 31, 2023

Copy link
Copy Markdown

Fixes #139. Implements @simon-staal's proposed solution:

The ZBarOrientation enum class specifies an UNKNOWN type as -1 here. However, when setting zbar_symbol_get_orientation, the c_uint type is passed here. Presumably if this was changed to c_int this would solve this issue?

The original zbar implementation defines zbar_orientation_t as enum with ZBAR_ORIENT_UNKNOWN = -1. Hence, the return type of zbar_symbol_get_orientation is signed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

-1 on uint? "4294967295 is not a valid ZBarOrientation"

2 participants