Skip to content

Improve Docker build security and efficiency for frontend #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nefrit0n merged 2 commits into from
May 4, 2026
Merged

Improve Docker build security and efficiency for frontend #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfdc938
fix(frontend): resolve Vite EACCES permission error in Docker dev con…
claude May 4, 2026
00d1d30
fix(ci): correct hadolint config path in pr.yml
claude May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ jobs:
- uses: hadolint/hadolint-action@v3.1.0
with:
dockerfile: ${{ matrix.dockerfile }}
config: .github/workflows/.hadolint.yaml
config: .github/.hadolint.yaml
format: sarif
output-file: hadolint-${{ strategy.job-index }}.sarif
no-fail: true
Expand Down
5 changes: 5 additions & 0 deletions frontend/.dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
node_modules
.vite
dist
.git
*.md
8 changes: 4 additions & 4 deletions frontend/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ WORKDIR /app
RUN chown -R node:node /app
USER node

COPY package.json package-lock.json* ./
COPY --chown=node:node package.json package-lock.json* ./
ENV NPM_CONFIG_INCLUDE=optional
RUN npm ci --include=optional

COPY . .
COPY --chown=node:node . .

EXPOSE 3000

Expand All @@ -22,11 +22,11 @@ WORKDIR /app
RUN chown -R node:node /app
USER node

COPY package.json package-lock.json* ./
COPY --chown=node:node package.json package-lock.json* ./
ENV NPM_CONFIG_INCLUDE=optional
RUN npm ci --include=optional

COPY . .
COPY --chown=node:node . .
RUN npm run build

# ── Stage: Production (nginx) ──
Expand Down
Loading