Minimal configs, enable easy CLI, ground work for test suite#1531
Open
dxqb wants to merge 1 commit into
Open
Conversation
This was referenced Jun 16, 2026
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
b3965d5 to
7be1a67
Compare
3 tasks
--preset-path lets a built-in preset be applied (without migration, since built-in presets are always saved in the current format) before the main config file. --config-value KEY=VALUE applies a final override after both, with dotted-path support for nested config objects - useful for scripting training runs without hand-editing a config file (e.g. overriding the output path or disabling compile per-run).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes it easy to run multiple presets using a minimal config. It does that by adding two things to
train.py:--preset-path: applies a built-in preset file before the main--config-pathconfig (without migration, since built-in presets are always saved in the current format).--config-value KEY=VALUE: applies a final override after both, with dotted-path support for nested config objects (e.g.ema.decay=0.99). Repeatable.Example:
./run-cmd.sh train --preset-path "training_presets/#flux2 LoRA 16GB.json" --config-path "test/minimal.json" --config-value output_model_destination=models/my_lora.safetensorsThe
minimal.json(added in #1545) is, as the name suggests, minimal:The idea is to layer config values on top of each other:
--config-valueoverridesBy doing that, your config can be very simple and isn't model-specific anymore.
This isn't a test suite, but it enables one by making it easier to run CLI trainings, @O-J1 @hameerabbasi — see #1545 for the smoke-test scripts built on top of this.
AI assistance