Address utf8 write bug when uploading JavaScript applications to device with fz-sdk#536
Open
bekindpleaserewind wants to merge 1 commit into
Open
Address utf8 write bug when uploading JavaScript applications to device with fz-sdk#536bekindpleaserewind wants to merge 1 commit into
bekindpleaserewind wants to merge 1 commit into
Conversation
bekindpleaserewind
requested review from
956MB,
HaxSam,
MatthewKuKanich,
Sil333033 and
WillyJL
as code owners
March 26, 2026 22:56
Member
|
nice find, thanks for the pr. please submit to upstream (https://github.com/flipperdevices/flipperzero-firmware) too |
Author
|
@WillyJL Thanks. I went ahead and submitted upstream at flipperdevices/flipperzero-firmware#4364 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
For the reviewer
*note this was tested against the most recent version of @next-flip/fz-sdk-mntm with success.