Open
Conversation
Contributor
|
ref #36 |
chaejunlee
reviewed
Jul 24, 2023
Contributor
chaejunlee
left a comment
chaejunlee
left a comment
There was a problem hiding this comment.
이미 머지된 다른 문서들을 참고해서 포맷을 맞춰주시면 좋을 것 같습니다 😀!!
리뷰 남겨드렸으니 확인 후 반영 부탁 드립니다!
| [Tailwind CSS](https://tailwindcss.com/)는 Next.js에서 잘 작동되는 유틸리티 우선의 CSS 프레임워크 입니다. | ||
|
|
||
| ## Installing Tailwind | ||
| <!-- is a utility-first CSS framework that works exceptionally well with Next.js. --> |
Contributor
There was a problem hiding this comment.
Suggested change
| <!-- is a utility-first CSS framework that works exceptionally well with Next.js. --> |
| Install the Tailwind CSS packages and run the `init` command to generate both the `tailwind.config.js` and `postcss.config.js` files: | ||
| ## Tailwind 설치 | ||
|
|
||
| <!-- Install the Tailwind CSS packages and run the `init` command to generate both the `tailwind.config.js` and `postcss.config.js` files: --> |
Contributor
There was a problem hiding this comment.
Suggested change
| <!-- Install the Tailwind CSS packages and run the `init` command to generate both the `tailwind.config.js` and `postcss.config.js` files: --> |
|
|
||
| <!-- Install the Tailwind CSS packages and run the `init` command to generate both the `tailwind.config.js` and `postcss.config.js` files: --> | ||
|
|
||
| Tailwind CSS 패키지들을 설치 후 `tailwind.config.js`파일과 `postcss.config.js`파일을 생성하기 위해 `init` 커맨드를 사용합니다. |
Contributor
There was a problem hiding this comment.
Suggested change
| Tailwind CSS 패키지들을 설치 후 `tailwind.config.js`파일과 `postcss.config.js`파일을 생성하기 위해 `init` 커맨드를 사용합니다. | |
| Tailwind CSS 패키지들을 설치 후 `tailwind.config.js` 파일과 `postcss.config.js` 파일을 생성하기 위해 `init` 커맨드를 사용합니다. |
Comment on lines
+34
to
+35
| <!-- | ||
| Inside `tailwind.config.js`, add paths to the files that will use Tailwind CSS class names: --> |
Contributor
There was a problem hiding this comment.
Suggested change
| <!-- | |
| Inside `tailwind.config.js`, add paths to the files that will use Tailwind CSS class names: --> |
| './components/**/*.{js,ts,jsx,tsx,mdx}', | ||
|
|
||
| // Or if using `src` directory: | ||
| //또는 `src` 디렉토리를 사용하는 경우에는: |
Contributor
There was a problem hiding this comment.
Suggested change
| //또는 `src` 디렉토리를 사용하는 경우에는: | |
| // 또는 `src` 디렉토리를 사용하는 경우라면 |
|
|
||
| ```jsx filename="app/layout.js" switcher | ||
| // These styles apply to every route in the application | ||
| // 이 스타일은 애플리케이션의 모든 루트에 적용됩니다. |
Contributor
There was a problem hiding this comment.
Suggested change
| // 이 스타일은 애플리케이션의 모든 루트에 적용됩니다. | |
| // 이 스타일은 애플리케이션의 모든 라우트에 적용됩니다. |
| ## 클래스를 이용하기 | ||
|
|
||
| After installing Tailwind CSS and adding the global styles, you can use Tailwind's utility classes in your application. | ||
| <!-- After installing Tailwind CSS and adding the global styles, you can use Tailwind's utility classes in your application. --> |
Contributor
There was a problem hiding this comment.
Suggested change
| <!-- After installing Tailwind CSS and adding the global styles, you can use Tailwind's utility classes in your application. --> |
| ``` | ||
|
|
||
| ## Usage with Turbopack | ||
| ## 터보 팩과 함께 사용 |
Contributor
There was a problem hiding this comment.
Suggested change
| ## 터보 팩과 함께 사용 | |
| ## 터보팩과 함께 사용 |
| ## Usage with Turbopack | ||
| ## 터보 팩과 함께 사용 | ||
|
|
||
| <!-- As of Next.js 13.1, Tailwind CSS and PostCSS are supported with [Turbopack](https://turbo.build/pack/docs/features/css#tailwind-css). --> |
Contributor
There was a problem hiding this comment.
Suggested change
| <!-- As of Next.js 13.1, Tailwind CSS and PostCSS are supported with [Turbopack](https://turbo.build/pack/docs/features/css#tailwind-css). --> |
| <!-- As of Next.js 13.1, Tailwind CSS and PostCSS are supported with [Turbopack](https://turbo.build/pack/docs/features/css#tailwind-css). --> | ||
|
|
||
| As of Next.js 13.1, Tailwind CSS and PostCSS are supported with [Turbopack](https://turbo.build/pack/docs/features/css#tailwind-css). | ||
| Next.js 13.1부터 Tailwind CSS 및 PostCSS는 [터보 팩](https://turbo.build/pack/docs/features/css#tailwind-css)에서 지원됩니다. |
Contributor
There was a problem hiding this comment.
Suggested change
| Next.js 13.1부터 Tailwind CSS 및 PostCSS는 [터보 팩](https://turbo.build/pack/docs/features/css#tailwind-css)에서 지원됩니다. | |
| Next.js 13.1부터 Tailwind CSS 및 PostCSS는 [터보팩](https://turbo.build/pack/docs/features/css#tailwind-css)에서 지원됩니다. |
Member
|
@nada1221 리뷰 이후 작업이 몇일 동안 이뤄지지 않아 9월 13일까지 작업이 없을 경우 이슈를 close하고 새로운 분에게 할당하겠습니다! |
Author
|
아 피드백이 왔었군요 수정 진행하고 다시 달겠습니다. |
yoo-jimin127
suggested changes
Sep 14, 2023
Contributor
yoo-jimin127
left a comment
yoo-jimin127
left a comment
There was a problem hiding this comment.
@nada1221 님 안녕하세요!
리뷰 반영 최종 확인 및 머지 담당자입니다.
현재 chaejunlee 님께서 작성해주신 리뷰 내용 중 반영되어 있지 않은 부분들이 몇가지 보이는데요,
예를 들어
//또는 `src` 디렉토리를 사용하는 경우에는:
과,
// 이 스타일은 애플리케이션의 모든 루트에 적용됩니다.
를 비롯해 몇가지 리뷰의 경우 반영이 필수적으로 필요해 보입니다!
올려주신 커밋에서 확인이 되지 않아, 한번 더 확인 부탁드립니다 :)
반영 작업 완료해주시면 언급 한 번만 부탁드릴게요!
감사합니다 :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
기여자용
문서 개선
pnpm prettier-fix를 실행하여 서식 문제를 해결합니다. - 문서 기여 가이드를 읽고 문서 지침을 따르는지 확인하세요: https://github.com/Nextjs-kr/Nextjs.ko/blob/main/packages/next/README.mdProgress
pnpm prettier-fixclose #36