fix: enhance DevicePluginDetector with normalization of time-sliced GPU#583
Open
Code2Life wants to merge 2 commits into
Open
fix: enhance DevicePluginDetector with normalization of time-sliced GPU#583Code2Life wants to merge 2 commits into
Code2Life wants to merge 2 commits into
Conversation
…PU IDs - Added `normalizeDeviceIDs` method to the `DevicePluginDetector` to handle de-duplication of time-sliced GPU IDs. - Updated `processDeviceState` to utilize the new normalization logic for both allocated and registered device IDs. - Enhanced tests in `detector_test.go` to verify the correct behavior of GPU ID normalization and its integration with the device plugin detection process. - Improved handling of vendor detectors to support resource name prefixes. This change improves the accuracy of GPU resource management in scenarios involving time-sliced devices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
normalizeDeviceIDsmethod to theDevicePluginDetectorto handle de-duplication of time-sliced GPU IDs.processDeviceStateto utilize the new normalization logic for both allocated and registered device IDs.detector_test.goto verify the correct behavior of GPU ID normalization and its integration with the device plugin detection process.This change improves the accuracy of GPU resource management in scenarios involving time-sliced devices.