-
Notifications
You must be signed in to change notification settings - Fork 0
[Draft] Test gemini code review: Feature/imprintfix #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: code-review
Are you sure you want to change the base?
Changes from all commits
8e3253c
cc3bbe9
c242681
db31e9f
f0a358b
a4444e7
1f53677
75f4e7d
fbe0495
ac0172e
5dbecc8
bcc1d7d
88b8533
30b6967
18f833d
53b9c90
3b131d5
a29762a
32b8157
2d6b385
f847448
a87fd23
7157552
78a03f0
11fb929
cfc00b3
67323d9
6dd5e06
9d471e6
28a806a
b0f20ed
a43b38b
7ac0954
b780ea6
6387ed6
d137e46
0ba1e0b
2116ad4
a56bd92
4bcfd4f
cddb28c
130d014
ecb9424
a896d78
34ab7b5
43ca737
cb3c59a
9b1550a
3088837
61526a5
f44aa48
2cd083a
d48b5a6
4f0f427
6c67df7
4df0929
591a0d2
ab807f2
a151aab
92d6137
9c27efe
8fd1c1b
14de7f1
7ca7625
599c683
ff162f3
cc11ea3
1d4984b
7ccc5f6
e265f34
5a297a6
ff5fc74
4b3a3b9
ccbcfdd
4d4780a
a7e1789
8c77ce4
216b1e5
c0f8c81
727a4b1
325a254
fb30d2c
e5ff109
7fe9e91
def0114
8492c30
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| +16 −16 | model/src/w3iogomd.F90 | |
| +73 −73 | model/src/w3iopomd.F90 | |
| +9 −7 | model/src/w3wavemd.F90 | |
| +170 −270 | model/src/wav_comp_nuopc.F90 | |
| +2 −2 | model/src/wav_history_mod.F90 | |
| +5 −55 | model/src/wav_import_export.F90 | |
| +6 −6 | model/src/wav_shel_inp.F90 | |
| +4 −8 | model/src/wav_shr_mod.F90 | |
| +1 −0 | model/src/wav_wrapper_mod.F90 |
| +59 −0 | .cicd/Jenkinsfile | |
| +4 −0 | docs/source/developers_guide.rst | |
| +20 −27 | stochastic_physics.F90 | |
| +27 −2 | unit_tests/compile_standalone.hera_gnu | |
| +101 −0 | unit_tests/input.nml | |
| +3 −3 | unit_tests/run_standalone.sh | |
| +25 −10 | unit_tests/standalone_stochy.F90 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| export BL_DATE=20250416 | ||
| export BL_DATE=20250502 |
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -1006,7 +1006,6 @@ export WW3_ICE='F' | |||||||||
| export WW3_IC1='F' | ||||||||||
| export WW3_IC5='F' | ||||||||||
| # ATMW | ||||||||||
| export WW3_MULTIGRID=true | ||||||||||
| export WW3_MODDEF=mod_def.glo_1deg | ||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||||||
| export MESH_WAV=mesh.glo_1deg.nc | ||||||||||
| export WW3_RSTFLDS=" " | ||||||||||
|
|
@@ -1392,8 +1391,8 @@ export_cmeps() { | |||||||||
| # mediator ocean albedo | ||||||||||
| export ocean_albedo_limit=0.06 | ||||||||||
| export use_mean_albedos=.false. | ||||||||||
| # WW3 (used in run_test only) | ||||||||||
| export WW3_MULTIGRID=false | ||||||||||
| # vector remapping | ||||||||||
| export MAPUV3D=true | ||||||||||
|
Comment on lines
+1394
to
+1395
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Comment on lines
+1394
to
+1395
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||||||
| } | ||||||||||
|
|
||||||||||
| export_cpl () | ||||||||||
|
Comment on lines
1397
to
1398
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||||||
|
|
@@ -1634,6 +1633,8 @@ export_datm_cdeps () | |||||||||
|
|
||||||||||
| # Set CMEPS component defaults | ||||||||||
| export_cmeps | ||||||||||
| # vector remapping | ||||||||||
| export MAPUV3D=false | ||||||||||
|
Comment on lines
+1636
to
+1637
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The
Suggested change
Comment on lines
+1636
to
+1637
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||||||
| # default configure | ||||||||||
| export UFS_CONFIGURE=ufs.configure.datm_cdeps.IN | ||||||||||
| export atm_model=datm | ||||||||||
|
|
||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -106,14 +106,8 @@ else | |
| fi | ||
|
|
||
| if [ $CPLWAV = .true. ]; then | ||
| if [ $WW3_MULTIGRID = 'true' ]; then | ||
| cp @[INPUTDATA_ROOT_WW3]/mod_def.pointsatmw mod_def.points | ||
| cp @[INPUTDATA_ROOT_WW3]/@[WW3_MODDEF] . | ||
| cp @[INPUTDATA_ROOT_WW3]/rmp_src* . | ||
| else | ||
| cp @[INPUTDATA_ROOT_WW3]/@[WW3_MODDEF] mod_def.ww3 | ||
| cp @[INPUTDATA_ROOT_WW3]/@[MESH_WAV] . | ||
| fi | ||
| fi | ||
|
|
||
|
Comment on lines
109
to
112
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| #inline post | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ if [ $WARM_START = .true. ]; then | |
| else | ||
| mkdir INPUT RESTART | ||
| cp -r @[INPUTDATA_ROOT]/${inputdir}/INPUT_C/* ./INPUT/. | ||
| fi | ||
| fi | ||
| if [ $TILEDFIX = .true. ]; then | ||
| if [ $CPLLND == .true. ]; then | ||
| cp @[INPUTDATA_ROOT]/FV3_fix_tiled/@[ATMRES]/@[ATMRES]*.nc INPUT/. | ||
|
|
@@ -26,14 +26,8 @@ else | |
| fi | ||
|
|
||
| if [ $CPLWAV = .true. ]; then | ||
| if [ $WW3_MULTIGRID = 'true' ]; then | ||
| cp @[INPUTDATA_ROOT_WW3]/mod_def.pointsatmw mod_def.points | ||
| cp @[INPUTDATA_ROOT_WW3]/@[WW3_MODDEF] . | ||
| cp @[INPUTDATA_ROOT_WW3]/rmp_src* . | ||
| else | ||
| cp @[INPUTDATA_ROOT_WW3]/@[WW3_MODDEF] mod_def.ww3 | ||
| cp @[INPUTDATA_ROOT_WW3]/@[MESH_WAV] . | ||
| fi | ||
| fi | ||
|
Comment on lines
29
to
31
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| #inline post | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable
WW3_MULTIGRIDis being removed. What is the justification for this removal? Does this variable no longer serve a purpose, or is its functionality being replaced by something else? Please provide context or documentation for this change.