Test cice warnings#26
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a Python script for monitoring compiler warnings, updates the CICE submodule to point to the Consortium repository, and refactors regression test scripts to reduce duplication. It also adds several new coupled model test configurations and updates CICE namelist parameters. Feedback focuses on improving the robustness of the warning check script by avoiding hardcoded branch names and removing redundant variable assignments in the new test scripts that could lead to incorrect thread counts.
| sys.exit(1) | ||
|
|
||
| log_directory = sys.argv[1] | ||
| base_branch = "develop" |
There was a problem hiding this comment.
The base branch is hardcoded to develop. This script will produce incorrect results if the pull request targets a different branch (e.g., a release branch or a hotfix branch). It is better to pass the base branch as an argument or use the GITHUB_BASE_REF environment variable to make the script more robust and reusable across different target branches.
| base_branch = "develop" | |
| base_branch = sys.argv[2] if len(sys.argv) > 2 else "develop" |
| export atm_omp_num_threads=$THRD_cpl_unstr | ||
| export med_omp_num_threads=$atm_omp_num_threads |
There was a problem hiding this comment.
These lines are redundant and potentially buggy. Line 21 overwrites the atm_omp_num_threads value set on line 11 with the default THRD_cpl_unstr. If the intention of this test was to use the MPI-specific thread count (THRD_cpl_unstr_mpi), line 21 effectively reverts that change. Removing line 21 allows line 22 to correctly use the value assigned on line 11.
export med_omp_num_threads=$atm_omp_num_threads
| export atm_omp_num_threads=$THRD_cpl_unstr | ||
| export med_omp_num_threads=$atm_omp_num_threads |
There was a problem hiding this comment.
Similar to other test scripts in this PR, line 23 overwrites the specific atm_omp_num_threads setting from line 11 with a global default. This redundancy should be cleaned up to ensure that if THRD_cpl_unstr_mpi is ever changed to differ from the default, the test actually uses the intended value.
export med_omp_num_threads=$atm_omp_num_threads
Commit Queue Requirements:
test_changes.listindicates which tests, if any, are changed by this PR. Committest_changes.list, even if it is empty.Description:
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Documentation:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: