Open
Conversation
Makefile would supply them using env-vars.
"$@" = I can pass in flags like `-j32` to make compiling faster, utilizing all 32 logical cores on my workstation.
IDK if this will work. Really.
|
|
||
| # Run "make help" for target help. | ||
|
|
||
| ifeq ($(MCU),) |
Owner
There was a problem hiding this comment.
Is this required? What id you use ?=, would this work?
Author
There was a problem hiding this comment.
Sure you can use ?=. This is just equivalent.
Owner
There was a problem hiding this comment.
?= looks fancier. Please use that, its also more simple and better understandable.
Owner
|
Looks like an interesting patch. Let me know once you fixed my notes. Thanks for taking the time :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.