Skip to content

fix: Update okta_classic.py to handle scenario when Okta MFA provider with factorType "push" may return no profiles #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
epierce merged 3 commits into from
Apr 12, 2026
Merged

fix: Update okta_classic.py to handle scenario when Okta MFA provider with factorType "push" may return no profiles #497

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4fa89b9
fix: Addressing possible case when Okta Verify App doesn't return a '…
Apr 10, 2026
3b0a651
test: Updated test_okta_classic_client.py to add coverage for _build_…
Apr 10, 2026
b49c27e
test: Updated test_okta_classic_client.py to add coverage for _build_…
Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion gimme_aws_creds/okta_classic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,7 +920,10 @@ def _build_factor_name(self, factor):
if factor['provider'] == 'DUO':
return factor['factorType'] + ": " + factor['provider'].capitalize()
elif factor['factorType'] == 'push':
return "Okta Verify App: " + factor['profile']['deviceType'] + ": " + factor['profile']['name']
if 'profile' in factor:
return "Okta Verify App: " + factor['profile']['deviceType'] + ": " + factor['profile']['name']
else:
return "Okta Verify App - push verification"
elif factor['factorType'] == 'sms':
return factor['factorType'] + ": " + factor['profile']['phoneNumber']
elif factor['factorType'] == 'email':
Expand Down