Merged
Conversation
mmerklinger
force-pushed
the
cleanup-rayon-threads
branch
from
19ed47d to
dbfaeff
Compare
This was referenced Apr 17, 2026
mmerklinger
force-pushed
the
cleanup-rayon-threads
branch
from
6ab9698 to
a63318f
Compare
mmerklinger
changed the title
mmerklinger
force-pushed
the
cleanup-rayon-threads
branch
2 times, most recently
from
80dbc5a to
58c7d25
Compare
mmerklinger
force-pushed
the
cleanup-rayon-threads
branch
from
58c7d25 to
ab6836b
Compare
sosthene-nitrokey
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has been found that in the current implementation the rayon thread pool doesn't terminate its spawned threads in time. This causes in some case a crash of the library on Windows (access violation exception) when the threads later wake up and try to access freed memory.
This PR disables the parallel operation with rayon on Windows, until a solution is found.