RFC 110: Add "inherit-as-list" language construct#5402
Closed
r-burns wants to merge 5 commits into
Closed
Conversation
Initial MVP implementation for [RFC 110](NixOS/rfcs#110)
This reverts commit 1a22abd. In preparation for revised implementation
Before:
```
[ inherit (attrs) a b c; ] := builtins.attrValues { inherit (attrs) a b c; }
```
After:
```
[ inherit (attrs) a b c; ] := [ attrs.a attrs.b attrs.c ];
```
The previous desugaring has some potentially nice properties such as
non-significant ordering and no-duplicate enforcement, but was
ultimately deemed unintuitive and too surprising in practical use.
|
I marked this as stale due to inactivity. → More info |
The new syntax is ``` attrs.[ a b c ] ``` as sugar for ``` [ attrs.a attrs.b attrs.c ] ```
Contributor
|
stale: re-open and re-base as needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial MVP implementation for RFC 110