profiles/minimal: reduce size by Izorkin · Pull Request #173661 · NixOS/nixpkgs

Izorkin · 2022-05-19T18:29:24Z

Description of changes

Minimize size netboot and iso images.
Splitted this PR - #170460

cc @SuperSandro2000

Things done

Izorkin · 2022-06-27T18:37:31Z

What does it take for this PR to be merged?

Izorkin · 2022-07-05T09:19:41Z

Rebased PR.
Removing commit 'nixos/installer/netboot: use makeInitrdNG' - #176796
cc @ajs124 @Lassulus @lheckemann

SuperSandro2000

nixos/modules/profiles/minimal.nix is also used for containers, right? Then I don't think we should disable man pages there. Also we should think about removing environment.noXlibs as it can cause quite weird problems when building certain packages and you didn't think about it while debugging.

Izorkin · 2022-07-05T14:18:34Z

@SuperSandro2000 virtualisation.containers does not use nixos/modules/profiles/minimal.nix.

Izorkin · 2022-07-05T14:34:18Z

Didn't not found mysself any problems with environment.noXlibs.

SuperSandro2000 · 2022-07-07T14:48:15Z

@SuperSandro2000 virtualisation.containers does not use nixos/modules/profiles/minimal.nix.

nspawn/nixos containers, not oci containers.

The last case is https://discourse.nixos.org/t/unable-to-install-paperless-ngx/19962

lheckemann · 2022-07-07T16:03:56Z

This should have a release notes entry, since it may require changes to people's configurations.

Izorkin · 2022-07-12T20:26:27Z

This should have a release notes entry, since it may require changes to people's configurations.

Added release notes.

SuperSandro2000 · 2022-07-15T23:43:46Z

That could be really dangerous and fill up your disk when logs in containers get no longer rotated. Also many people don't even know that the container uses this profile.

This module is used only in tests and in minimal ISO image. Should not affect working to containers. And it was enabled by default recently.

This module is used only in tests and in minimal ISO image.

No, it is also included for nixos-containers because otherwise the stupid environment.noXlibs option wouldn't mess with some software builds.

I tested with this configuration:

containers.test-man = { autoStart = true; privateNetwork = true; hostBridge = "br0"; localAddress = "10.11.0.1/24"; config = { pkgs, config, ... }: { system.extraDependencies = [ pkgs.hello ]; services.openssh = { enable = true; }; }; };

Changes to nixos/modules/profiles/minimal.nix did not affect the container

🤔 maybe I was doing something wonky but lxc container imports minimal profile which I was using for the container https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/virtualisation/lxc-container.nix#L54

@SuperSandro2000 add this patch?

diff --git a/nixos/doc/manual/from_md/release-notes/rl-2211.section.xml b/nixos/doc/manual/from_md/release-notes/rl-2211.section.xml index 6a7032e1963..392f79cb51e 100644 --- a/nixos/doc/manual/from_md/release-notes/rl-2211.section.xml +++ b/nixos/doc/manual/from_md/release-notes/rl-2211.section.xml @@ -368,6 +368,11 @@ <literal>nixos/modules/profiles/minimal.nix</literal> profile. </para> </listitem> + <listitem> + <para> + Now lxc containers don't use minimal profile. + </para> + </listitem> <listitem> <para> There is a new module for the <literal>xfconf</literal> diff --git a/nixos/doc/manual/release-notes/rl-2211.section.md b/nixos/doc/manual/release-notes/rl-2211.section.md index b56be16127b..817262affd8 100644 --- a/nixos/doc/manual/release-notes/rl-2211.section.md +++ b/nixos/doc/manual/release-notes/rl-2211.section.md @@ -134,6 +134,8 @@ Use `configure.packages` instead. - The minimal ISO image now use `nixos/modules/profiles/minimal.nix` profile. +- Now lxc containers don't use minimal profile. + - There is a new module for the `xfconf` program (the Xfce configuration storage system), which has a dbus service.  diff --git a/nixos/modules/virtualisation/lxc-container.nix b/nixos/modules/virtualisation/lxc-container.nix index d3a2e0ed151..b6b744dfbca 100644 --- a/nixos/modules/virtualisation/lxc-container.nix +++ b/nixos/modules/virtualisation/lxc-container.nix @@ -51,7 +51,6 @@ in { imports = [ ../installer/cd-dvd/channel.nix - ../profiles/minimal.nix ../profiles/clone-config.nix ];

Or this variant:

diff --git a/nixos/modules/virtualisation/lxc-container.nix b/nixos/modules/virtualisation/lxc-container.nix index d3a2e0ed151..b6b4dcff1d0 100644 --- a/nixos/modules/virtualisation/lxc-container.nix +++ b/nixos/modules/virtualisation/lxc-container.nix @@ -55,6 +55,8 @@ in ../profiles/clone-config.nix ]; + environment.noXlibs = lib.mkOverride 500 false; + options = { virtualisation.lxc = { templates = mkOption {

cc @SuperSandro2000

@SuperSandro2000 Is there a consensus on this remark?

noXlibs should not be enabled by default. It is an advanced setting that required multiple overrides to build on all my machines, which is not acceptable for normal users.

logrotation should not be disabled in lxc otherwise your disk can completely fill up which should be avoided with good defaults.

Izorkin · 2022-10-19T19:21:04Z

Rebased PR.
What is needed to get this PR merged? :)

Artturin · 2022-10-19T22:56:15Z

rebased the pr on master(git rebase --onto master HEAD~7)

and built the iso (nix build -f ./nixos/release-combined.nix nixos.iso_minimal.x86_64-linux) on master with and without this pr

but the size seems to be larger?

now

du -shc --apparent-size $(readlink -f result/iso/nixos-minimal-22.11pre56789.gfedcba-x86_64-linux.iso)
3.8G	/nix/store/w6aalmkc9w9mvmlmvcc4a6567h5ncrqg-nixos-minimal-22.11pre56789.gfedcba-x86_64-linux.iso/iso/nixos-minimal-22.11pre56789.gfedcba-x86_64-linux.iso
3.8G	total

before

$ du -shc --apparent-size $(readlink -f result/iso/nixos-minimal-22.11pre56789.gfedcba-x86_64-linux.iso)
2.2G	/nix/store/6lby9i5kx22qqgpin23klwpbf6nn6vxm-nixos-minimal-22.11pre56789.gfedcba-x86_64-linux.iso/iso/nixos-minimal-22.11pre56789.gfedcba-x86_64-linux.iso
2.2G	total

Izorkin · 2022-10-29T19:27:32Z

Fix conflicts.

ck3d

LGTM

RaitoBezarius · 2022-12-01T15:24:56Z

Can you move the release notes to 23.05 ? Think it's good to merge now.

Izorkin · 2022-12-01T17:39:05Z

Can you move the release notes to 23.05 ? Think it's good to merge now.

Updated.

Artturin · 2022-12-03T18:57:38Z

From somewhere, are added nixpkgs sources with git history to image:

du -d 1 -hc  /nix/.ro-store/5q1kw0svyl0j3p1jwc0yv20x1sa63bw5-source/
1.2G    /nix/.ro-store/5q1kw0svyl0j3p1jwc0yv20x1sa63bw5-source/.git
53K     /nix/.ro-store/5q1kw0svyl0j3p1jwc0yv20x1sa63bw5-source/.github
788K    /nix/.ro-store/5q1kw0svyl0j3p1jwc0yv20x1sa63bw5-source/doc
479K    /nix/.ro-store/5q1kw0svyl0j3p1jwc0yv20x1sa63bw5-source/lib
563K    /nix/.ro-store/5q1kw0svyl0j3p1jwc0yv20x1sa63bw5-source/maintainers
13M     /nix/.ro-store/5q1kw0svyl0j3p1jwc0yv20x1sa63bw5-source/nixos
109M    /nix/.ro-store/5q1kw0svyl0j3p1jwc0yv20x1sa63bw5-source/pkgs
1.3G    /nix/.ro-store/5q1kw0svyl0j3p1jwc0yv20x1sa63bw5-source/
1.3G    total

Will fix it
#204178

Izorkin · 2022-12-07T18:48:29Z

Resolve conflicts.

Izorkin · 2022-12-09T10:07:25Z

Resolve conflicts.
Who can merge PR?

Izorkin · 2022-12-09T10:18:35Z

Thanks!

ncfavier · 2022-12-09T10:19:16Z

Note that the discussion about disabling logrotate in LXC containers is still open.

Izorkin · 2022-12-09T10:22:08Z

Note that the discussion about disabling logrotate in LXC containers is still open.

I will try to test the lxc containers a little later.

SuperSandro2000 · 2022-12-09T15:04:11Z

Note that the discussion about disabling logrotate in LXC containers is still open.

We should fix this regression ASAP because it could fill up the disk completely if things go really south.

Izorkin · 2022-12-09T18:20:39Z

We should fix this regression ASAP because it could fill up the disk completely if things go really south.

Created PR - #205346

github-actions Bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 19, 2022

ofborg Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 19, 2022

Mindavi added the 6.topic: closure size The final size of a derivation, including its dependencies label May 19, 2022

SuperSandro2000 requested a review from Artturin May 19, 2022 23:19

SuperSandro2000 reviewed Jun 28, 2022

View reviewed changes

Comment thread nixos/modules/installer/cd-dvd/installation-cd-minimal.nix Outdated

Comment thread nixos/modules/profiles/minimal.nix Outdated

Izorkin force-pushed the profiles-reduce branch 3 times, most recently from 70e6a1e to c6f28bd Compare July 5, 2022 09:11

SuperSandro2000 reviewed Jul 5, 2022

View reviewed changes

Izorkin force-pushed the profiles-reduce branch from c6f28bd to e28aea5 Compare July 12, 2022 20:12

github-actions Bot added 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation labels Jul 12, 2022

Izorkin force-pushed the profiles-reduce branch from e28aea5 to b1ea960 Compare July 12, 2022 20:21

SuperSandro2000 reviewed Jul 15, 2022

View reviewed changes

lheckemann approved these changes Jul 28, 2022

View reviewed changes

fpletz approved these changes Jul 30, 2022

View reviewed changes

Izorkin force-pushed the profiles-reduce branch from b1ea960 to e0379ec Compare August 9, 2022 04:49

Izorkin requested a review from SuperSandro2000 September 4, 2022 18:50

Izorkin force-pushed the profiles-reduce branch from e0379ec to cf4602c Compare October 19, 2022 19:20

Izorkin force-pushed the profiles-reduce branch from cf4602c to 11ce0d6 Compare October 29, 2022 19:27

ck3d approved these changes Oct 30, 2022

View reviewed changes

MatthewCroughan approved these changes Oct 30, 2022

View reviewed changes

SuperSandro2000 removed their request for review October 30, 2022 18:01

Izorkin force-pushed the profiles-reduce branch from 11ce0d6 to 3729d07 Compare December 1, 2022 17:38

Izorkin force-pushed the profiles-reduce branch from 3729d07 to 7dc27ca Compare December 7, 2022 18:48

ncfavier reviewed Dec 7, 2022

View reviewed changes

Comment thread nixos/modules/installer/cd-dvd/installation-cd-minimal.nix Outdated

ncfavier approved these changes Dec 8, 2022

View reviewed changes

Izorkin added 7 commits December 9, 2022 13:03

nixos/profiles/minimal: disable documentation

df22e41

nixos/profiles/minimal: disable logrotate service

ee85845

nixos/profiles/minimal: disable udisks service

362d351

iso/minimal: use minimal profile

191d211

iso/minimal: use mkForce

309d6a3

nixos/installer/netboot-minimal: enable man

0c6ce0d

nixos/profiles/minimal: add release notes

731d496

Izorkin force-pushed the profiles-reduce branch from 7dc27ca to 731d496 Compare December 9, 2022 10:05

Lassulus merged commit 05c1c92 into NixOS:master Dec 9, 2022

Izorkin deleted the profiles-reduce branch December 9, 2022 10:18

ncfavier mentioned this pull request Jan 15, 2023

nixos/installer: include a substitutable copy of the manual #210966

Closed

13 tasks

Uh oh!

Uh oh!

Conversation

Izorkin commented May 19, 2022

Description of changes

Things done

Uh oh!

Izorkin commented Jun 27, 2022

Uh oh!

Uh oh!

Uh oh!

Izorkin commented Jul 5, 2022

Uh oh!

SuperSandro2000 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Izorkin commented Jul 5, 2022

Uh oh!

Izorkin commented Jul 5, 2022

Uh oh!

SuperSandro2000 commented Jul 7, 2022

Uh oh!

lheckemann commented Jul 7, 2022

Uh oh!

Izorkin commented Jul 12, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SuperSandro2000 Dec 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Izorkin commented Oct 19, 2022

Uh oh!

Artturin commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Izorkin commented Oct 29, 2022

Uh oh!

ck3d left a comment

Choose a reason for hiding this comment

Uh oh!

RaitoBezarius commented Dec 1, 2022

Uh oh!

Izorkin commented Dec 1, 2022

Uh oh!

Artturin commented Dec 3, 2022

Uh oh!

Izorkin commented Dec 7, 2022

Uh oh!

Uh oh!

Izorkin commented Dec 9, 2022

Uh oh!

Izorkin commented Dec 9, 2022

Uh oh!

ncfavier commented Dec 9, 2022

Uh oh!

Izorkin commented Dec 9, 2022

Uh oh!

SuperSandro2000 commented Dec 9, 2022

Uh oh!

Izorkin commented Dec 9, 2022

Uh oh!

SuperSandro2000 left a comment •

edited

Loading

SuperSandro2000 Dec 9, 2022 •

edited

Loading

Artturin commented Oct 19, 2022 •

edited

Loading