Skip to content

wslay: init at 1.1.1#263831

Merged
wegank merged 2 commits into
NixOS:masterfrom
whiteley:wslay-init
Oct 28, 2023
Merged

wslay: init at 1.1.1#263831
wegank merged 2 commits into
NixOS:masterfrom
whiteley:wslay-init

Conversation

@whiteley

@whiteley whiteley commented Oct 27, 2023

Copy link
Copy Markdown
Contributor

Grabbed from #170919

Description of changes

Wslay is a WebSocket library written in C.
https://tatsuhiro-t.github.io/wslay/

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Built internal software with this library successfully

@ofborg ofborg Bot added the 8.has: package (new) This PR adds a new package label Oct 27, 2023
@ofborg ofborg Bot requested a review from pingiun October 27, 2023 19:51
@ofborg ofborg Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 27, 2023
pingiun
pingiun reviewed Oct 27, 2023
View reviewed changes
Comment thread pkgs/by-name/ws/wslay/package.nix
@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 28, 2023
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 28, 2023
@ofborg ofborg Bot requested a review from pingiun October 28, 2023 17:54
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 28, 2023
@wegank wegank merged commit 044ac2b into NixOS:master Oct 28, 2023
@whiteley whiteley deleted the wslay-init branch October 31, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wegank wegank wegank left review comments
+1 more reviewer
@pingiun pingiun pingiun approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@whiteley @pingiun @wegank @delroth