Skip to content

treewide: remove all-packages.nix overrides of packages defined in by-name (A-C)#469771

Merged
Aleksanaa merged 17 commits into
NixOS:masterfrom
mdaniels5757:remove-all-packages-overrides-of-by-name_a-c
Dec 29, 2025
Merged

treewide: remove all-packages.nix overrides of packages defined in by-name (A-C)#469771
Aleksanaa merged 17 commits into
NixOS:masterfrom
mdaniels5757:remove-all-packages-overrides-of-by-name_a-c

Conversation

@mdaniels5757

@mdaniels5757 mdaniels5757 commented Dec 11, 2025

Copy link
Copy Markdown
Member

This is a step towards resurrecting #454525.

(I did not use the work already done in #453948 for this, unfortunately, as I noticed the link when preparing this PR... Oh well.)

Should be 0 rebuilds.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 11, 2025
@mdaniels5757 mdaniels5757 marked this pull request as ready for review December 11, 2025 01:40
@nixpkgs-ci nixpkgs-ci Bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Dec 11, 2025
@nixpkgs-ci nixpkgs-ci Bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Dec 11, 2025
fufexan
fufexan reviewed Dec 11, 2025
View reviewed changes

@fufexan fufexan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aquamarine lgtm

HHR2020
HHR2020 reviewed Dec 12, 2025
View reviewed changes

@HHR2020 HHR2020 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clash-verge-rev lgtm

hatch01
hatch01 approved these changes Dec 12, 2025
View reviewed changes

@hatch01 hatch01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-uml lgtm

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 469771
Commit: 43e8e2fbb56115d162139db1c8c9f4f804e7adfc (subsequent changes)
Merge: e85dc98d5bf18046167199c67d08d110f64372fe

Logs: https://github.com/hatch01/nixpkgs-review-gha/actions/runs/20172604460

x86_64-linux

✅ No rebuilds

aarch64-linux

✅ No rebuilds

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Dec 12, 2025
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Dec 12, 2025
amarshall
amarshall approved these changes Dec 13, 2025
View reviewed changes

@amarshall amarshall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay for blender.

@nixpkgs-ci nixpkgs-ci Bot removed the 12.approvals: 2 This PR was reviewed and approved by two persons. label Dec 13, 2025
@mdaniels5757 mdaniels5757 force-pushed the remove-all-packages-overrides-of-by-name_a-c branch from 5908d9c to d0b5281 Compare December 27, 2025 00:42
@mdaniels5757

mdaniels5757 commented Dec 27, 2025

Copy link
Copy Markdown
Member Author

Rebased (although there were no conflicts, at least locally...).

@Aleksanaa given that it's been 2 weeks without objections (and with multiple approvals), do you think this can be merged/would you be willing to dismiss your review?

@deftdawg

deftdawg commented Dec 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@mdaniels5757 did you look at my review comment, I didn't see a reply.

@mdaniels5757

mdaniels5757 commented Dec 27, 2025

Copy link
Copy Markdown
Member Author

@deftdawg I don't see a review comment from you. What was it/are you sure you submitted it?

deftdawg
deftdawg suggested changes Dec 27, 2025
View reviewed changes
Comment thread pkgs/by-name/co/cope/package.nix
@deftdawg

deftdawg commented Dec 27, 2025

Copy link
Copy Markdown
Contributor

It was in pending... I guess you couldn't see it then... sorry about that.

@mdaniels5757 mdaniels5757 force-pushed the remove-all-packages-overrides-of-by-name_a-c branch from d0b5281 to b63f34d Compare December 27, 2025 01:09
@mdaniels5757

mdaniels5757 commented Dec 29, 2025

Copy link
Copy Markdown
Member Author

@Aleksanaa given that it's been 2 weeks without objections (and with multiple approvals), do you think this can be merged/would you be willing to dismiss your review?

bumping :)

@Aleksanaa Aleksanaa dismissed their stale review December 29, 2025 04:18

okay, nobody made objections

@Aleksanaa Aleksanaa added this pull request to the merge queue Dec 29, 2025
Merged via the queue into NixOS:master with commit 17e67dc Dec 29, 2025
29 checks passed
@qweered

qweered commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

🎉
Continued in #474456

@mdaniels5757 mdaniels5757 deleted the remove-all-packages-overrides-of-by-name_a-c branch December 29, 2025 13:34
@mdaniels5757 mdaniels5757 mentioned this pull request Jan 25, 2026
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aherrmann aherrmann Awaiting requested review from aherrmann
@avdv avdv Awaiting requested review from avdv
@Bot-wxt1221 Bot-wxt1221 Awaiting requested review from Bot-wxt1221
@donovanglover donovanglover Awaiting requested review from donovanglover
@getchoo getchoo Awaiting requested review from getchoo
@groodt groodt Awaiting requested review from groodt
@jcumming jcumming Awaiting requested review from jcumming
@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa
8 more reviewers
@fufexan fufexan fufexan left review comments
@HHR2020 HHR2020 HHR2020 left review comments
@amarshall amarshall amarshall approved these changes
@illdefined illdefined illdefined approved these changes
@deftdawg deftdawg deftdawg approved these changes
@qweered qweered qweered approved these changes
@hatch01 hatch01 hatch01 approved these changes
@boltzmannrain boltzmannrain boltzmannrain approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@mdaniels5757 @amarshall @qweered @deftdawg @illdefined @fufexan @Aleksanaa @hatch01 @HHR2020 @boltzmannrain