aws-cloudformation-languageserver: init at 1.7.0

[mbarneyjr]

This inits aws-cloudformation-languageserver at version 1.4.0 (latest as of creating this PR).

The AWS CloudFormation LanguageServer is an LSP server that works on CloudFormation files. I've been using this (packaged almost identically) in my personal Neovim configuration successfully.

Other notes:

• The actual INSTALLATION.md guide recommends unzipping the release archive and running node /path/to/install-location/cfn-lsp-server-standalone.js --stdio. This derivation uses makeWrapper to use node from nixpkgs to run the cfn-lsp-server-standalone.js file.
• There is an update.sh script to update the sources.json that the package.nix uses to pass the hashes into fetchzip and version to mkDerivation, etc. I've pointed passthru.updateScript to it too.

This is my first new package contribution, if I'm missing anything I'm more than happy to receive any feedback!

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

[mbarneyjr]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 489310
Commit: 1e3d9fdb0f42b34140d074a1866466eec8db9d90

---

aarch64-darwin

✅ 1 package built:

• aws-cloudformation-languageserver

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/6506

[SuperSandro2000]

Why are we not building the software from source?

[mbarneyjr]

Why are we not building the software from source?

This is the method documented in the aws-cloudformation-languageserver repository to install it: INSTALLATION.md

Thanks for the review! I'll incorporate your suggestions into this PR

[mbarneyjr]

I've incorporated all of the suggested changes, it builds and the update script still runs. Let me know if there's anything else you'd like me to change, thanks again! 🙏

[SuperSandro2000]

This is the method documented in the aws-cloudformation-languageserver repository to install it: INSTALLATION.md

Yeah, because building it from source for the average consumer is probably a bit overkill and takes a bit to long, but we, as the distro, could do it, right? Can you try that? If it doesn't work out we can keep the binary download but I think we should really try it at least.

[mbarneyjr]

Can you try that? If it doesn't work out we can keep the binary download but I think we should really try it at least.

That makes sense to me, I'll give it an effort to build from source as part of the derivation and keep you posted

[mbarneyjr]

The current commit has a build-from-source approach. The upstream project build involves a webpack config that tries to run its own npm ci command to a temp node_modules directory that would break when running in the sandbox, so I've patched the webpack config to skip that step and just copy the node_modules that gets produced from buildNpmPackage itself. The build-from-source approach makes this package more accessible to those that prefer/require fromSource, but the upstream build process is a bit atypical so this package isn't as "pure" to the upstream in that sense. I'm happy to maintain the package under either approach that we feel would be best for nixpkgs

I've tested the build and it still seems to function on my macos and nixos machines, verified with my neovim config running it

(if we're happy with the from-source approach I'll remove the update.sh and sources.json)

[mbarneyjr]

@SuperSandro2000 I don't mean to bug you, are you able to continue reviewing this?

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/6808

[mbarneyjr]

Fixed the __structuredAttrs issue from the CI check

[mbarneyjr]

Updated to CloudFormation LanguageServer 1.7.0, rebased master to resolve conflicts, and tested to make sure it still works

[mbarneyjr]

Per a review I've gotten on a separate PR:

The finalAttrs pattern is recommended for all new packages

we can use tag here for a slightly more efficient download from GitHub

updating this package to use finalAttrs instead of rec and tag instead of rev