Skip to content

mgccli: init at 0.61.2#500774

Open
fabiob wants to merge 1 commit into
NixOS:masterfrom
fabiob:mgccli
Open

mgccli: init at 0.61.2#500774
fabiob wants to merge 1 commit into
NixOS:masterfrom
fabiob:mgccli

Conversation

@fabiob

@fabiob fabiob commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

This PR adds a new package for the Magalu Cloud Command-Line Interface (mgccli).

Magalu Cloud is a cloud provider in Brazil. The CLI is documented at https://docs.magalu.cloud/docs/devops-tools/cli-mgc/overview .

The previous PR #474912 was accidentally closed.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Mar 17, 2026
@fabiob fabiob force-pushed the mgccli branch 2 times, most recently from ae3eb8c to 311629e Compare March 18, 2026 23:41

@Knuspii Knuspii left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not follow nixpkgs conventions.

Please use the format:
<pkgname>: <action> <version>

e.g.:
mgccli: init at 0.53.0


platforms can be simplified to:
platforms = lib.platforms.all; or platforms = lib.platforms.unix;

Or you can also just remove it.

@nixpkgs-ci nixpkgs-ci Bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Mar 23, 2026
@fabiob fabiob force-pushed the mgccli branch 2 times, most recently from 8f3a600 to 443f01c Compare March 24, 2026 20:07
@fabiob fabiob requested a review from Knuspii March 24, 2026 20:19
@fabiob fabiob changed the title mgccli: added mgccli: init at 0.53.0 Mar 24, 2026
@fabiob fabiob force-pushed the mgccli branch 2 times, most recently from 1ba0818 to 06945da Compare March 24, 2026 21:30
@fabiob

fabiob commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review, @Knuspii . I've also took the time to read a little more about the conventions and modern approaches, so I also:

  • Changed the rec for the modern finalAttrs approach;
  • Added (and tested) nix-update as the update script on passthru.updateScript;
  • Added a very simple test on passthru.tests.

@Knuspii Knuspii left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdenv is unused.
But looks mostly good. 👍

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 25, 2026
@fabiob fabiob force-pushed the mgccli branch 2 times, most recently from 53246c5 to 5c1be5f Compare March 30, 2026 17:37
@nixpkgs-ci nixpkgs-ci Bot added the 8.has: package (new) This PR adds a new package label Mar 30, 2026
@fabiob

fabiob commented Apr 6, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 500774
Commit: 5c1be5f8d8d3eb684dafc6bdbc855984fc7fd9a0


x86_64-linux

✅ 1 package built:
  • mgccli

@fabiob fabiob force-pushed the mgccli branch 3 times, most recently from acd74c8 to 76f4bbc Compare April 13, 2026 17:17
@fabiob fabiob changed the title mgccli: init at 0.53.0 mgccli: init at 0.55.0 May 7, 2026
@fabiob fabiob changed the title mgccli: init at 0.55.0 mgccli: init at 0.59.0 May 24, 2026
@nixpkgs-ci nixpkgs-ci Bot removed 12.first-time contribution This PR is the author's first one; please be gentle! 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels May 27, 2026
@fabiob fabiob changed the title mgccli: init at 0.59.0 mgccli: init at 0.61.0 May 31, 2026
@fabiob fabiob changed the title mgccli: init at 0.61.0 mgccli: init at 0.61.2 Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants