Skip to content

obsidian: fix app icon for linux, adopt#505535

Closed
Prince213 wants to merge 2 commits into
NixOS:masterfrom
Prince213:push-yqqulmqnxzvl
Closed

obsidian: fix app icon for linux, adopt#505535
Prince213 wants to merge 2 commits into
NixOS:masterfrom
Prince213:push-yqqulmqnxzvl

Conversation

@Prince213

@Prince213 Prince213 commented Apr 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #505407.
Closes #505078.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot requested review from kashw2, w-lfchen and zaninime April 1, 2026 03:27
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Apr 1, 2026
@Prince213 Prince213 mentioned this pull request Apr 1, 2026
Closed
3 tasks
@Prince213 Prince213 requested a review from pyrox0 April 1, 2026 03:29
@Prince213

Prince213 commented Apr 1, 2026

Copy link
Copy Markdown
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 505535
Commit: 7f8cc6d12899fb0d468deecd7eebf5922d2f741b (subsequent changes)
Merge: f4e953757cf910b96a5b41578ea6edece637c18f

Logs: https://github.com/Prince213/nixpkgs-review-gha/actions/runs/23830547041

x86_64-linux

✅ 1 package built:
  • obsidian

aarch64-linux

✅ 1 package built:
  • obsidian

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@zspher zspher mentioned this pull request Apr 1, 2026
Closed
13 tasks
@Prince213 Prince213 changed the title obsidian: fix app icon for linux obsidian: fix app icon for linux, adopt Apr 1, 2026
@Prince213 Prince213 added 0.kind: regression Something that worked before working no longer 0.kind: package adoption Requests or PRs for adopting packages that have no maintainers labels Apr 1, 2026
w-lfchen
w-lfchen reviewed Apr 1, 2026
View reviewed changes

@w-lfchen w-lfchen left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upstream uses electron 39, as per their patch notes.
it might be simpler to pin the electron version as we have in the past, see #380617.

i don't have a strong opinion on which option is better, though i would prefer to have a comment with the patch describing when it can be removed/why it was added

nitinbhat972
nitinbhat972 previously approved these changes Apr 1, 2026
View reviewed changes
@nitinbhat972 nitinbhat972 self-requested a review April 1, 2026 14:41
nitinbhat972
nitinbhat972 reviewed Apr 1, 2026
View reviewed changes

@nitinbhat972 nitinbhat972 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I accidentally approved this PR due to a misclick. Please ignore my approval.

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 1, 2026
@nixpkgs-ci nixpkgs-ci Bot removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 8, 2026
@w-lfchen w-lfchen mentioned this pull request Apr 14, 2026
Merged
13 tasks
@KucharczykL

KucharczykL commented Apr 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Is there a general guideline regarding version pinning when packaging Electron apps?

@Prince213

Prince213 commented Apr 18, 2026

Copy link
Copy Markdown
Member Author

My thoughts are that we could use the same version as upstream until it's EOL. And I think #510075 could be better in this regard.

@w-lfchen

w-lfchen commented Apr 18, 2026

Copy link
Copy Markdown
Member

#510075 has been merged

@w-lfchen w-lfchen closed this Apr 18, 2026
@emilioziniades emilioziniades mentioned this pull request Apr 22, 2026
Closed
3 tasks
@Prince213 Prince213 deleted the push-yqqulmqnxzvl branch May 11, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kashw2 kashw2 Awaiting requested review from kashw2
@zaninime zaninime Awaiting requested review from zaninime
@pyrox0 pyrox0 Awaiting requested review from pyrox0
2 more reviewers
@nitinbhat972 nitinbhat972 nitinbhat972 left review comments
@w-lfchen w-lfchen w-lfchen left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

0.kind: package adoption Requests or PRs for adopting packages that have no maintainers 0.kind: regression Something that worked before working no longer 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

obsidian: Appears as "electron" After Launch

4 participants

@Prince213 @KucharczykL @w-lfchen @nitinbhat972