Skip to content

obsidian: pin electron to 39; add prince213 as maintainer #510075

Merged
Prince213 merged 2 commits into
NixOS:masterfrom
w-lfchen:obsidian/pin-electron
Apr 18, 2026
Merged

obsidian: pin electron to 39; add prince213 as maintainer #510075
Prince213 merged 2 commits into
NixOS:masterfrom
w-lfchen:obsidian/pin-electron

Conversation

@w-lfchen

@w-lfchen w-lfchen commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

closes #505078
supersedes #505535 and #505407

this removes the electron input, replacing it with electron_39.
the method used in #380617 no longer applies since #483820.
this pr will break any electron overrides once it hits master, but this seems to be normal judging by the other prs relating to #483820.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@w-lfchen w-lfchen requested a review from Prince213 April 14, 2026 19:51
@w-lfchen

w-lfchen commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

@Prince213 i've opened this pr due to inactivity on #505535.
do you still want to be added as a maintainer?
if so, please file a new pr should this one get merged before you find the time to reply.

@nixpkgs-ci nixpkgs-ci Bot requested review from kashw2 and zaninime April 14, 2026 19:56
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 14, 2026
@w-lfchen w-lfchen mentioned this pull request Apr 14, 2026
Closed
3 tasks
@Prince213

Prince213 commented Apr 15, 2026

Copy link
Copy Markdown
Member

I'm waiting for maintainer feedback on #505535 before merging, and yes I'd like to become a maintainer.

@w-lfchen w-lfchen changed the title obsidian: pin electron to 39 obsidian: pin electron to 39; add prince213 as maintainer Apr 15, 2026
@w-lfchen

w-lfchen commented Apr 15, 2026

Copy link
Copy Markdown
Member Author

for my feedback as a maintainer, see #505535 (review).

i don't have a strong preference towards which option is better, i'd default to conforming to the obsidian version upstream expects as done here because it is simpler.

i can't put much more time into this issue for now due to personal reasons, so i'll leave it up to you/others to decide which pr to merge and which to close.

Prince213
Prince213 reviewed Apr 18, 2026
View reviewed changes

@Prince213 Prince213 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be better until upstream update their electron version, or when electron_39 reached EOL.

Comment thread pkgs/by-name/ob/obsidian/package.nix Outdated
Comment thread pkgs/by-name/ob/obsidian/package.nix
@Prince213 Prince213 mentioned this pull request Apr 18, 2026
Closed
13 tasks
@w-lfchen w-lfchen force-pushed the obsidian/pin-electron branch from d8c2891 to 9153c15 Compare April 18, 2026 11:10
@w-lfchen w-lfchen requested a review from Prince213 April 18, 2026 11:11
Prince213
Prince213 approved these changes Apr 18, 2026
View reviewed changes

@Prince213 Prince213 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on x86_64-linux.

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Apr 18, 2026
@Prince213

Prince213 commented Apr 18, 2026

Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 510075
Commit: 9153c15dafd8458f7142996fe5f75781f75a10fd (subsequent changes)
Merge: 3a29fe5d8cafbcb3803ac4960d1c0897661bc922

Logs: https://github.com/Prince213/nixpkgs-review-gha/actions/runs/24603566077

x86_64-linux

✅ 1 package built:
  • obsidian

aarch64-linux

✅ 1 package built:
  • obsidian

@Prince213 Prince213 added this pull request to the merge queue Apr 18, 2026
@Prince213 Prince213 added the backport release-25.11 Backport PR automatically label Apr 18, 2026
Merged via the queue into NixOS:master with commit 929227e Apr 18, 2026
31 of 32 checks passed
@nixpkgs-ci

nixpkgs-ci Bot commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Successfully created backport PR for release-25.11:

@github-actions github-actions Bot added the 8.has: port to stable This PR already has a backport to the stable release. label Apr 18, 2026
@nixpkgs-ci nixpkgs-ci Bot mentioned this pull request Apr 18, 2026
Merged
JBoeCodes added a commit to JBoeCodes/holonix that referenced this pull request Apr 25, 2026
@JBoeCodes @claude
Rename obsidian electron override to electron_39
0eebe11 
Upstream nixpkgs switched obsidian's electron argument from `electron`
to `electron_39` (pinned to match the upstream Obsidian bundle, see
NixOS/nixpkgs#510075). The rebuild failed with "unexpected argument
'electron'" until the override matched.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@hesprs hesprs mentioned this pull request May 13, 2026
Closed
13 tasks
@w-lfchen w-lfchen deleted the obsidian/pin-electron branch May 18, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Prince213 Prince213 Prince213 approved these changes
@kashw2 kashw2 Awaiting requested review from kashw2
@zaninime zaninime Awaiting requested review from zaninime

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. backport release-25.11 Backport PR automatically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

obsidian: Appears as "electron" After Launch

2 participants

@w-lfchen @Prince213