kak-tree-sitter: add option to prebuild and bundle parsers#518336
Open
rhelmot wants to merge 1 commit into
Open
kak-tree-sitter: add option to prebuild and bundle parsers#518336rhelmot wants to merge 1 commit into
rhelmot wants to merge 1 commit into
Conversation
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
rhelmot
force-pushed
the
kak-tree-sitter-complete
branch
from
c6b137c to
3e611b7
Compare
Contributor
Author
|
Hilariously, since we "add a new package" and I have to adjust the old package to use __structuredAttrs and so forth, we have to target staging since #510526 hasn't made it to master. |
nixpkgs-ci
Bot
removed
10.rebuild-darwin: 1
Contributor
FYI it's on master now |
nixpkgs-ci
Bot
added
the
2.status: merge conflict
rhelmot
force-pushed
the
kak-tree-sitter-complete
branch
from
3e611b7 to
f532a01
Compare
nixpkgs-ci
Bot
removed
the
2.status: merge conflict
Contributor
Author
And so indeed does this PR target master again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on a kakoune nixos module, and this seems like a meaningful unit to contribute right now.
Normally, you're supposed to use
ktsctlat runtime to build the tree sitter parsers. This is not very nix-y, and furthermore is kind of annoying to have to do on each of my machines! Also, if we're using tinycc for the compiler, we're missing out on a lot of good compiler optimizations from gcc and clang!This PR adds a parameter to the kak-tree-sitter wrapper which indicates which parsers to automatically bundle. In order to make them available at runtime, it wraps the kak-tree-sitter binary to link them into the user's $XDG_DATA_HOME, which is the only place that it knows to look for them...
Also adds toplevel
kak-tree-sitter-completewhich shortcuts bundling all parsers, both for convenience and to get them into hydra.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.