llm-wiki: init at 0.4.10 [LLM-assisted contribution]#521355
Draft
futile wants to merge 2 commits into
Draft
Conversation
Assisted-by: Codex:gpt-5.5-medium
Assisted-by: Codex:gpt-5.5-medium
Contributor
Author
|
Actually, the app is not that great. While I created this derivation to use it myself, I'm not sure it's actually a good app that I want to be responsible for. And I have no idea if I'll even continue using it, so I'll put this PR into draft-mode for now, so hopefully nobody spends time on this until I decide what I want to do. At the same time, it's here if someone wants/needs it 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISCLOSURE: THE COMMITS IN THIS PR WERE CREATED WITH LLM-ASSISTANCE.
I did not use any LLM whatsoever to write this PR description.
I have carefully reviewed the LLM output and understand what the new package is doing, and have done my best to make sure it's high-quality.
This includes having looked up things that weren't clear to me, and where necessary improved them and/or left comment(s) to clear up why things are being done.
I have (also using AI) looked up similar packages and existing conventions in this repo to determine the solutions and styles that are most idiomatic in nixpkgs.
I have done this just like I would have if I had written the code myself, or when doing a code review.
Please let me know if I missed something.
I am interested in learning, but this is the first new package I contribute to nixpkgs (I have contributed package updates etc. before), so I might have gotten something wrong.
I fully intend to take responsibility for this new package, and I don't intend to simply pass off reviewer feedback to an LLM or anything like that.
That said, let's move on to actual content of this PR.
Things done
This PR adds a new package,
llm-wiki, which packages https://github.com/nashsu/llm_wiki, (mostly) building it from source.I say "mostly" because the tool originally vendors a binary version of
pdfium, which the package replaces with nixpkgs'pdfium-binary, but that is still a binary package (afaiu). That is the only binary part of the build (to the best of my knowledge).I have only built this on x86_64-linux, but have made sure that it evals on all platforms the tool claims to support and that
cargo-tauri.hookalso supports.This PR also adds myself to maintainer-list.nix, since I wasn't on it before.
The commit adding me to that is ordered before (older-than) the commit introducing the new package.
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Since this an LLM-assisted contribution, I looked for guidance/policy around that, and found #514587. Following that (even though it's not yet merged, I thought it best to follow it nevertheless), I added the appropriate
Assisted-by:git trailers, and am including the new checkbox that the PR suggests as well: