Skip to content

rust-cbindgen: 0.29.3 -> 0.29.4#531195

Merged
mweinelt merged 2 commits into
NixOS:staging-nextfrom
mweinelt:rust-cbindgen-0.29.4
Jun 30, 2026
Merged

rust-cbindgen: 0.29.3 -> 0.29.4#531195
mweinelt merged 2 commits into
NixOS:staging-nextfrom
mweinelt:rust-cbindgen-0.29.4

Conversation

@mweinelt

@mweinelt mweinelt commented Jun 13, 2026

Copy link
Copy Markdown
Member

https://github.com/mozilla/cbindgen/blob/v0.29.4/CHANGES

Things done

nixpkgs-branch-check[bot]

This comment was marked as outdated.

Sign in to view

@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Jun 13, 2026
@mweinelt

mweinelt commented Jun 13, 2026

Copy link
Copy Markdown
Member Author

Breaks firefox 151.0.4 and probably other versions.

@mweinelt mweinelt marked this pull request as draft June 13, 2026 00:52
@nixpkgs-ci nixpkgs-ci Bot removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Jun 13, 2026
@twassman twassman mentioned this pull request Jun 29, 2026
Open
14 tasks
@twassman

twassman commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Firefox Beta 153.0b5 appears to require cbindgen >= 0.29.4.

Also, Firefox breakage may be mozilla/cbindgen#1165?

@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 29, 2026
@mweinelt mweinelt force-pushed the rust-cbindgen-0.29.4 branch from 4796fa3 to 7ec21ab Compare June 30, 2026 00:51
@nixpkgs-ci nixpkgs-ci Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 30, 2026
@mweinelt mweinelt changed the base branch from master to staging-next June 30, 2026 01:10
@mweinelt mweinelt marked this pull request as ready for review June 30, 2026 01:10
@nixpkgs-ci nixpkgs-ci Bot closed this Jun 30, 2026
@nixpkgs-ci nixpkgs-ci Bot reopened this Jun 30, 2026
@mweinelt

mweinelt commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

Thanks, patch picked. This PR has to go via staging-nex I'm afraid, because it rebuilds mesa, too.

@mweinelt
buildMozillaMach: backport cbindgen 0.29.4 compat
1cb1099 
Cherry-picked from 153 to remain compatible with cbindgen 0.29.4.
@mweinelt mweinelt force-pushed the rust-cbindgen-0.29.4 branch from 10eab65 to 1cb1099 Compare June 30, 2026 01:11
@nixpkgs-branch-check nixpkgs-branch-check Bot dismissed their stale review June 30, 2026 01:20

Review dismissed automatically

@nixpkgs-ci nixpkgs-ci Bot removed the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Jun 30, 2026
@mweinelt mweinelt added the backport staging-26.05 Backport PR automatically label Jun 30, 2026
@mweinelt mweinelt added this pull request to the merge queue Jun 30, 2026
@mweinelt

mweinelt commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

Built140.12.0esr with the patch.

@mweinelt mweinelt changed the title rust-cbindgen: 0.29.2 -> 0.29.4 rust-cbindgen: 0.29.3 -> 0.29.4 Jun 30, 2026
Merged via the queue into NixOS:staging-next with commit 1f55c59 Jun 30, 2026
28 checks passed
@mweinelt mweinelt deleted the rust-cbindgen-0.29.4 branch June 30, 2026 02:15
@nixpkgs-ci

nixpkgs-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Successfully created backport PR for staging-26.05:

@nixpkgs-ci nixpkgs-ci Bot mentioned this pull request Jun 30, 2026
Merged
@github-actions github-actions Bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nixpkgs-branch-check nixpkgs-branch-check[bot] nixpkgs-branch-check[bot] left review comments
@azahi azahi Awaiting requested review from azahi
@booxter booxter Awaiting requested review from booxter
@DominicWrege DominicWrege Awaiting requested review from DominicWrege
@fpletz fpletz Awaiting requested review from fpletz
@Hythera Hythera Awaiting requested review from Hythera
@jopejoe1 jopejoe1 Awaiting requested review from jopejoe1
@lovesegfault lovesegfault Awaiting requested review from lovesegfault
@mBornand mBornand Awaiting requested review from mBornand
@nbp nbp Awaiting requested review from nbp
@rhendric rhendric Awaiting requested review from rhendric
@vcunat vcunat Awaiting requested review from vcunat
@wolfgangwalther wolfgangwalther Awaiting requested review from wolfgangwalther

Assignees

No one assigned

Labels

8.has: package (update) This PR updates a package to a newer version 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. backport staging-26.05 Backport PR automatically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mweinelt @twassman