Skip to content

various: move some hooks to pkgs/by-name#532125

Merged
layus merged 1 commit into
NixOS:masterfrom
mdaniels5757:move-setup-hooks-to-by-name
Jun 16, 2026
Merged

various: move some hooks to pkgs/by-name#532125
layus merged 1 commit into
NixOS:masterfrom
mdaniels5757:move-setup-hooks-to-by-name

Conversation

@mdaniels5757

@mdaniels5757 mdaniels5757 commented Jun 15, 2026

Copy link
Copy Markdown
Member

Things done

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 15, 2026
@mdaniels5757 mdaniels5757 marked this pull request as ready for review June 15, 2026 23:43
@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 16, 2026

@Scrumplex Scrumplex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for autoPatchelfHook

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jun 16, 2026
Comment thread pkgs/by-name/au/autoPatchelfHook/package.nix

@layus layus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we decide we want all the tooling in pkgs/by-name too ?

Comment thread ci/OWNERS
Comment thread pkgs/by-name/au/auto-patchelf/package.nix
@layus layus added this pull request to the merge queue Jun 16, 2026
@layus

layus commented Jun 16, 2026

Copy link
Copy Markdown
Member

Thanks for the update, it's tedious work, thanks for doing it.

Merged via the queue into NixOS:master with commit 6aa26dc Jun 16, 2026
41 checks passed
@qweered

qweered commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Maybe in the future we want to have package set for hooks? NixOS/rfcs#197
Anyway LGTM for now, we always can move them

@mdaniels5757 mdaniels5757 deleted the move-setup-hooks-to-by-name branch June 16, 2026 23:04
@philiptaron

Copy link
Copy Markdown
Contributor

I'd be against making a package set for hooks. What I find most ergonomic is making a passthru derivation named "hook" so that (for instance) the ant hook is ant.hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants